player/loadfile: possibly do a reset of sd_ass when turning on video #17278
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be done otherwise it could technically increment forever if you constant reset.
It's a pretty niche case, but if you start a file with no video with animated ass subtitles and then turned on the video later, the subtitles would not actually be rendered animated. This because the subtitles were already decoded, and we do not do a check for animations expect in the specific case of an image being played back on the video since the check can be quite expensive. To fix this edge case, we just need to reset the ass before doing the track switch in the case where we go from no video to a track that's an image. SD_CTRL_RESET_SOFT is added as a a sub_ctrl to accomplish this. Fixes mpv-player#17268.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.