fix(cleanup): remove phantom dirs from _resolve_cache_directories (#5082)#5795
Merged
mrveiss merged 1 commit intoDev_new_guifrom Apr 24, 2026
Merged
fix(cleanup): remove phantom dirs from _resolve_cache_directories (#5082)#5795mrveiss merged 1 commit intoDev_new_guifrom
mrveiss merged 1 commit intoDev_new_guifrom
Conversation
) embeddings_cache and chunks_temp have zero write sites in the codebase. exports is written only by KnowledgeDocuments.export_all_data(), which has no call sites and is dead code. Remove all three to eliminate false signals; DATA_DIR/cache already covers real cache sinks via rglob. Update docstring to document which modules write to each covered directory. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
embeddings_cache,chunks_temp,exportsfrom_resolve_cache_directories()— all three have zero write sites in the codebaseexportshas a write site indocuments.pybut it has zero call sites (dead code) so the dir is never createdDATA_DIR/cache(rglob) already coversdata/cache/claude_responses/fromgraceful_degradation.pyTEMP_DIRalready coveredTest Plan
pytest autobot-backend/tasks/ -q→ 17 passed, 0 failedpython3 -m py_compile knowledge_tasks.py→ syntax okCloses #5082
🤖 Generated with Claude Code