You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am thinking of duplicating the vresions pages on Core and X docs, first of all because historically they had different release pace. I've extracted the logic for generating the versions in one place so we can reuse it. Some of the content will be duplicated, but I still think it's fine to have two different pages. The current page can't be in the current shape directly reusable on MUI X anyways.
Todo:
make sure the next.mui.com is down before moving forward
cherry pick the change in older docs
Add back all versions in the select on older versions's docs
Maybe it makes sense to build this like the notifications? a json on master with all the versions, then fetch it in getStaticProps. Then we don't need to update every old branch when a new version comes out, just deploy it.
Maybe it makes sense to build this like the notifications? a json on master with all the versions, then fetch it in getStaticProps. Then we don't need to update every old branch when a new version comes out, just deploy it.
With this logic too we don't need to update older versions (once they get to this version). The difference would be that this logic depends on the docs branches, and that one would be manually created. I am ok with that option too, it's simple.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docsImprovements or additions to the documentation.needs cherry-pickThe PR should be cherry-picked to master after merge.PR: out-of-dateThe pull request has merge conflicts and can't be merged.v5.xv6.xv7.xv8.x
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am thinking of duplicating the vresions pages on Core and X docs, first of all because historically they had different release pace. I've extracted the logic for generating the versions in one place so we can reuse it. Some of the content will be duplicated, but I still think it's fine to have two different pages. The current page can't be in the current shape directly reusable on MUI X anyways.
Todo: