Open
Conversation
mj12albert
added
type: bug
mj12albert
force-pushed
the
fix-drawer-transition-jump
branch
from
e48034b to
1b9b646
Compare
Bundle size
Deploy previewhttps://deploy-preview-48308--material-ui.netlify.app/ Check out the code infra dashboard for more information about this PR. |
mj12albert
force-pushed
the
fix-drawer-transition-jump
branch
from
1b9b646 to
fc1e0f2
Compare
mj12albert
force-pushed
the
fix-drawer-transition-jump
branch
from
fc1e0f2 to
8213aaa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16463
Before: https://stackblitz.com/edit/rq6e2eoh?file=src%2FDemo.tsx
After: https://stackblitz.com/edit/rq6e2eoh-jcm6h4wn?file=src%2FDemo.tsx
Watch the red edge of the drawer, before the fix, it shifts to the left before closing.
Drawer now sets
closeAfterTransition: trueby default, which should be ok since the only user-perceivable change is the timing of scroll unlock (before vs after transition)