Skip to content

several bugfixes#5

Open
375gnu wants to merge 4 commits into
mutoh:masterfrom
375gnu:myfixes
Open

several bugfixes#5
375gnu wants to merge 4 commits into
mutoh:masterfrom
375gnu:myfixes

Conversation

@375gnu

@375gnu 375gnu commented Jul 14, 2012

Copy link
Copy Markdown

These patches are from debian package.

dc31612: closes debian bug #600713
Allows Locale.current= accept a value of Locale::TagList (output of Locale.current)

7e496cd: fixes driver loading under $SAFE>0

0ef254f: fixes various bugs with charset handling, debian bugs #520181, #521169

cf17e51: fixes incorrect call to java.util.Locale.new in test/test_driver_jruby.rb

kou added a commit to ruby-gettext/locale that referenced this pull request Aug 22, 2012
Fix the fourth report of mutoh#5.

Patch by Hleb Valoshka. Thanks!!!
kou added a commit to ruby-gettext/locale that referenced this pull request Aug 22, 2012
LC_CTYPES should be checked instead of LC_MESSAGES.

Fix the third report of mutoh#5.

Debian bug #520181:
  http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=520181

Patch by Hleb Valoshka. Thanks!!!
Rreported by Adeodato Simó. Thanks!!!
@kou

kou commented Aug 22, 2012

Copy link
Copy Markdown

Thanks for your patches.
I merged almost your patches at https://github.com/ruby-gettext/locale.
But I couldn't understand a problem that is described in http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=521169.
It seems that LANG=en is the problem not locale gem problem.
Could you describe me about the problem?

@375gnu

375gnu commented Aug 22, 2012

Copy link
Copy Markdown
Author

I don't know what I was thinking about #521169, but my patches have no relation to it :) It looks like current Driver::Posix doesn't sets LANG, and this bug is related only to 1.93.

@kou

kou commented Aug 23, 2012

Copy link
Copy Markdown

Thanks for your comment!
OK. I'll ignore #521169!

@375gnu

375gnu commented May 10, 2013

Copy link
Copy Markdown
Author

I've noticed only recently that you, kou, have changed LC_CTYPE into LC_CTYPES. That's not correct, change it back to LC_CTYPE. You may use this trivial patch from debian.

Also you haven't integrated this patch (it' a part of commit 0ef254f mentioned above ). Without it Locale.current.charset in C/POSIX locale returns nothing instead of ANSI_X3.4-1968.

And please enable issues reporting for your repository like you did for gettext.

kou added a commit to ruby-gettext/locale that referenced this pull request May 10, 2013
LC_CTYPES ->
LC_CTYPE

GitHub: mutoh#5

Patch by Hleb Valoshka. Thanks!!!
kou added a commit to ruby-gettext/locale that referenced this pull request May 10, 2013
Debian: #520181
GitHub: mutoh#5

Reported by Hleb Valoshka. Thanks!!!
@kou

kou commented May 10, 2013

Copy link
Copy Markdown

Thanks.
I've mereged your patches.

And please enable issues reporting for your repository like you did for gettext.

OK. I opened https://github.com/ruby-gettext/locale/issues.

375gnu pushed a commit to 375gnu/locale that referenced this pull request Sep 14, 2015
DL is obsolete on ruby 2.2.

Patch by moguno. Thanks!!!
msk pushed a commit to msk/pkgsrc that referenced this pull request May 11, 2026
# News

## 2.0.8: 2012-08-29

Package fix release.

### Fixes

  * Added missing .yardopts file.

## 2.0.7: 2012-08-29

Package fix release.

### Fixes

  * Added missing this file. [Reported by Takahiro Kambe]

### Thanks

  * Takahiro Kambe

## 2.0.6: 2012-08-29

Ruby 1.9 on Windows support release.

### Improvements

  * Worked with invalid LANGUAGE variable value. It's just
    ignored. [Patch by Alexey l.Froloff] [Reported by Friedrich, Axel]
  * Added workaround for Ruby 1.8.6.
  * Supported multiple `Locale.init` call in the same process.
  * Supportd Ruby 1.9 on Windows.
  * Supported `Locale.current = Locale.current`.
    [GitHub#mutoh/locale#5] [Debian#600713]
    [Reported by Martin Hradil and Hleb Valoshka]
  * Supported `Locale.init` on `$SAFE > 0`.
    [GitHub#mutoh/locale#5] [Reported by Hleb Valoshka]
  * Added a Rack middleware `Locale::Middleware` that initializes locale by
    client request.

### Tests

  * Fixed a problem that tests for Windows break other tests on non
    Windows platform. [Patch by J. Pablo Fernández]
  * [jruby] Fixed wrong variant format.
    [GitHub#mutoh/locale#5] [Patch by Hleb Valoshka.]
  * Fixed wrong environment variable check. `LC_CTYPES` is checked
    instead of `LC_MESSAGES`.
    [GitHub#mutoh/locale#5] [Debian#520181]
    [Reported by Adeodato Simó] [Patch by Hleb Valoshka]

### Thanks

  * Masao Mutoh
  * Alexey l.Froloff
  * Friedrich, Axel
  * J. Pablo Fernández
  * Martin Hradil
  * Hleb Valoshka
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants