-
Notifications
You must be signed in to change notification settings - Fork 49
Reorg of the Usage section of the docs #881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
e4c5b99 to
1174f15
Compare
|
This is really great! 😍 One thing that stand out to me: |
|
Love this work @melissawm! Much better than main :) Some thoughts:
|
|
as mentioned in docs meeting, I love this reorg ❤️ I dropped by because I noticed in the napari help menu we link to some of these guides, and I wanted to flag it in case we need to update any of those URLs. I don't think we do? Because it looks like it links to the file and we don't move the file. But just wanted to flag it and ask. |
Exactly! I can remove this from the ToC for now but we do think this is important, and was something users brought up during the hackathon. @DragaDoncila I will verify the help menu - good callout, I think we should be fine but we should check anyways. Worst case scenario we can also include redirects. EDIT: Only the Getting Started link needs to change to "https://napari.org/{VERSION}/getting_started/start_index.html", here's the PR: napari/napari#8455 |
|
@melissawm Looks great. Not sure if in or out of scope, but I think we can shorten a few headings:
|
|
@willingc Thanks Carol! For tutorials and workshops I'm 💯 , for "Using layers" that's what we had before, and @TimMonko brought up something he saw on a talk which we agreed on, which is having the subject (layers in this case) be upfront in these titles so readers can skim better (Tim would you mind dropping a link here?) However I'm not opposed to finding a shorter title if you have ideas! Maybe just "Layers guide"? |
|
Layers Guide would be great. Thanks @melissawm and @TimMonko |
willingc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @melissawm
|
@melissawm Maybe change the card to match Layers guide too. Same with Quickstart and Workshops.
|
Czaki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this changes
8d57535 to
139a628
Compare
|
Updated! |
|
Hi @melissawm. This looks great! BTW I created the docs locally using the pixi instructions and it worked really easily even though I'm not really a pixi user. I tried to go through the docs systematically and here are a few things I noticed:
|
|
All great points!
You can get started already if you want 😉 |
|
Thank you so much @guiwitz ! Excellent points - I will try to address them in my next commit 😄 |
|
bump |
9aba60b to
6e2ca27
Compare
|
Hello, folks! I tried addressing all the comments above. It may not be perfect but I'd like to merge this for 0.7.0 and we can continue improving in the meantime. I don't know how to solve the codespell errors though - the release notes seem to have some kind of formatting error at the source? Anyway, @guiwitz if you can take a look soon that would be awesome. There is certainly room for improvements in all of these changes but at least we have a starting point. Thanks! |
| (napari-quick-start)= | ||
|
|
||
| # Quick start | ||
| # Quickstart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My dictionary and my wife suggest this should be reverted to two words. cc: @napari/copy
| # Quickstart | |
| # Quick start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@psobolewskiPhD Both versions are now acceptable. Quickstart has become the norm for technical guides, while quick start means beginning quickly. I'm fine with either though would lean toward one word.
| print('the cell area is: ', props[0].area) | ||
| ``` | ||
|
|
||
| Alternatively, try [this plugin](https://www.napari-hub.org/plugins/napari-skimage-regionprops) to have the result in a table form. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The one linked here doesn't really work anymore as far as I can tell. Let's use the newer better one from Guillaume!
| Alternatively, try [this plugin](https://napari-hub.org/plugins/napari-skimage.html) to use a GUI widget instead of the console. |
|
|
||
| Choose one of the options below to install napari as a Python package. | ||
|
|
||
| ::::::\{tab-set} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh, yes. This is a weird side effect of the linter, something's messed up in those configs. I'll fix, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh, yes. This is a weird side effect of the linter, something's messed up in those configs. I'll fix, thanks!
|
|
||
| Click the tile below to jump to the installation instructions for your operating system. | ||
|
|
||
| ::::\{grid} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| ## Solving common problems | ||
|
|
||
| ### napari does not launch with `No Qt bindings could be found` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For followup: we should move this to the Troubleshooting page and link that page here.
| @@ -0,0 +1 @@ | |||
| # Open images in napari | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copy-paste from quick start, just so it's not empty. We should make a follow-up issue to improve on this.
| # Open images in napari | |
| # Open images in napari | |
| napari natively supports tiff and many other formats supported by [skimage.io.imread](https://scikit-image.org/docs/dev/api/skimage.io.html) as input image file format. | |
| Try with your own images or download [this ome tiff file](https://downloads.openmicroscopy.org/images/OME-TIFF/2016-06/MitoCheck/00001_01.ome.tiff). | |
| Additional input file formats may be supported [by plugins](https://www.napari-hub.org/). | |
| Try [napari-aicsimageio](https://www.napari-hub.org/plugins/napari-aicsimageio) if you have czi, lif, or nd2 files. | |
| Once you have the proper plugin installed, use File > Open Files(s) | |
| and select the image file, or simply drag and drop the image into napari. | |
| For demo purpose, we will use a sample image that comes with napari. | |
| ### Option 1: Using the GUI to open an image | |
| 1. In napari, go to `File -> Open Sample -> napari built-ins -> Cell` | |
|  | |
| ### Option 2: Using the napari console to open an image | |
| 1. Open napari IPython console | |
|  | |
| 2. Type | |
| ```python | |
| from skimage import data | |
| viewer.add_image(data.cell(), name='cell') | |
| ``` | |
| ```{code-cell} ipython3 | |
| --- | |
| tags: [remove-input] | |
| --- | |
| import napari | |
| from napari.utils import nbscreenshot | |
| viewer = napari.Viewer() | |
| from skimage import data | |
| viewer.add_image(data.cell(), name='cell') | |
| nbscreenshot(viewer, alt_text="image of a single cell opened in napari viewer") | |
| ``` | |
| ```{note} | |
| Once you have a napari viewer open, you can also make a new `Image` layer from an image (or URL to an image) copied to your Clipboard using `File -> New Image from Clipboard` menu item (keybinding {kbd}`Command/Ctrl+N`). | |
| ``` |
psobolewskiPhD
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I left some minor comments, which arn't really blockers but nice to haves.
The real issue is the tiles and grids in getting_startedinstallation.md page not rendering right, at least in the circle previews.
It looks like the colon fencing (in place of backtick fencing) isn't working right, because other places look fine.
| annotation and analysis of large multi-dimensional images. | ||
|
|
||
| ````{grid} | ||
| ```{grid-item-card} napari quick start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@melissawm To keep things easy to scan and consistent across pages, I suggest simplifying the title of the card from "napari quick start" to "Quickstart".




References and relevant issues
N/A
Description
At the napari hackathon @ gloBIAS, we had the chance to discuss the docs organization with a few users and came up with ideas for potential improvements to our Usage section. We also discussed some changes to our API docs, but those will be handled separately.
This is a first very rough draft that is clearly incomplete, but I wanted to stash it somewhere so the work can continue.EDIT: This is now ready for review. It only touches the first sections of the user guide but I think this is reasonable for now. This was discussed at the docs meeting this week (nov 20/21).