Open
Conversation
It did create weird plot behavior
The data vector might vary and the behavior should equal the Arduino plotter
Author
|
@nathandunk Hi, could you kindly review my pull request when you have a moment? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #22 so that labeled variables are supported as in the Arduino plotter.
In addition, the plotter does not try to parse random text lines anymore which led to weird graphs.
Another change is not to remove unlabeled data points anymore if the new unlabeled data vector is smaller than before. This make the behavior of BetterSerialPlotter closer to the one of the Arduino IDE.