lddtree: Respect LD_LIBRARY_PATH when resolving dependency#23
Open
Shootfast wants to merge 1 commit intoncopa:mainfrom
Open
lddtree: Respect LD_LIBRARY_PATH when resolving dependency#23Shootfast wants to merge 1 commit intoncopa:mainfrom
Shootfast wants to merge 1 commit intoncopa:mainfrom
Conversation
The code was not early returning after finding the correct elf along LD_LIBRARY_PATH, which resulted in incorrect libraries being returned, particularly if there was an alternate lib in the default system location.
Owner
|
Do you think you can add a testcase also? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code was not early returning after finding the correct elf along LD_LIBRARY_PATH, which resulted in incorrect libraries being returned, particularly if there was an alternate lib in the default system location.