Removed obsolete sync mixin and methods#28
Open
delphikettle wants to merge 2 commits into
Open
Conversation
insomnes
approved these changes
Jul 8, 2026
mosquito
approved these changes
Jul 8, 2026
There was a problem hiding this comment.
Pull request overview
This PR removes the obsolete synchronous HTTP client/mixin layer and consolidates the internal API client implementation around httpx.AsyncClient, making the internal _internals client surface async-only.
Changes:
- Deleted the legacy sync/async mixins module and removed all sync overload stubs across v1 client mixins.
- Moved request sending and API-call handling into
ClientBaseusinghttpx.AsyncClient. - Simplified the internal client class hierarchy to a single
ContreeClient(ClientBase, V1Mixin)and updated type-check baselines accordingly.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| contree_sdk/_internals/lib/mixins.py | Removes legacy sync + async mixin implementations (file deleted). |
| contree_sdk/_internals/lib/client_base.py | Consolidates request/response lifecycle into an async-only ClientBase using AsyncClient. |
| contree_sdk/_internals/lib/api_decorator.py | Updates decorator typing targets from the removed base client type to ClientBase. |
| contree_sdk/_internals/client/v1/operations.py | Removes sync overloads and makes operation endpoints async-only stubs. |
| contree_sdk/_internals/client/v1/instances.py | Removes sync overloads and makes instance endpoints async-only stubs. |
| contree_sdk/_internals/client/v1/inspect.py | Removes sync overloads and makes inspect endpoints async-only stubs. |
| contree_sdk/_internals/client/v1/images.py | Removes sync overloads and makes image endpoints async-only stubs. |
| contree_sdk/_internals/client/v1/files.py | Removes sync overloads and makes file endpoints async-only stubs. |
| contree_sdk/_internals/client/v1/auth.py | Removes sync overloads and makes auth endpoint async-only stubs. |
| contree_sdk/_internals/client/client.py | Removes the split client base / sync client types in favor of a single async-only ContreeClient. |
| .ty/baseline.yaml | Updates type-checker baseline to reflect removed overload-related diagnostics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
delphikettle
force-pushed
the
feature/langchain-integration
branch
from
July 10, 2026 15:36
f34564a to
41aa5c9
Compare
delphikettle
force-pushed
the
feature/delete-obsolete-sync-mixins
branch
from
July 10, 2026 15:40
997337f to
5e3af97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.