-
Notifications
You must be signed in to change notification settings - Fork 60
SCHED-1741: Make sure we have Active or Passive check to drain nodes where there are empty libnvidia.so files (amended) #2684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
IronhandedLayman
wants to merge
1
commit into
main
Choose a base branch
from
feature/SCHED-1741-a
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
40 changes: 40 additions & 0 deletions
40
helm/slurm-cluster/slurm_scripts/check_nvidia_libraries.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| #!/bin/bash | ||
|
|
||
| set -euxo pipefail | ||
|
|
||
| fail_if_lib_dne () { | ||
| checklib=$1 | ||
| if python -c "import ctypes; ctypes.CDLL('$checklib')"; then | ||
| echo "...found $checklib, continuing" | ||
| else | ||
| echo "ERROR: missing $checklib" | ||
| exit 1 | ||
| fi | ||
| } | ||
|
|
||
| # first check if I can load libnvidia-ml.so.1, because nothing works without it | ||
| # (also not a typo, looks specifically for .1) | ||
|
|
||
| fail_if_lib_dne "libnvidia-ml.so.1" | ||
|
|
||
| # get list of base Nvidia libraries to check from nvidia-container-cli | ||
| full_library_list=$(nvidia-container-cli list -l | grep \\.so) | ||
| for x in $full_library_list; do | ||
| fail_if_lib_dne "$x" | ||
| done | ||
|
|
||
| # check against a list of commonly needed CUDA libraries that are common in a | ||
| # standard Pytorch training session | ||
|
|
||
| cudalibs="libcuda libcudart libcublas libcublasLt libcufft libcurand libcusolver libcusparse libcudnn libnccl libucp libucs libuct libgdrapi libmpi libnuma" | ||
| libs_w_version="libibverbs.so.1 librdmacm.so.1 libgomp.so.1" | ||
|
|
||
| for x in $cudalibs; do | ||
| fail_if_lib_dne "$x.so" | ||
| done | ||
| for x in $libs_w_version; do | ||
| fail_if_lib_dne "$x" | ||
| done | ||
|
|
||
| echo "OK: all libraries exist" | ||
| exit 0 |
17 changes: 17 additions & 0 deletions
17
helm/slurm-cluster/slurm_scripts/check_nvidia_libraries.sh.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "name": "check_nvidia_libraries", | ||
| "command": "./check_nvidia_libraries.sh", | ||
| "platforms": ["8xGPU", "1xGPU", "4xGPU"], | ||
| "skip_for_cpu_jobs": false, | ||
| "skip_for_partial_gpu_jobs": false, | ||
| "skip_for_reservation_prefixes": [], | ||
| "contexts": ["prolog", "hc_program"], | ||
| "node_states": ["any"], | ||
| "on_fail": "drain", | ||
| "on_ok": "undrain", | ||
| "reason_base": "[node_problem] $name", | ||
| "reason_append_details": true, | ||
| "run_in_jail": true, | ||
| "log": "slurm_scripts/$worker.$name.$context.out", | ||
| "need_env": [] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All nodes drained with
[node_problem]prefix are being automatically replaced by Soperator automation.But these drains show issues with hardware, not software.
This check doesn't show hardware issues, so automatic node replacement isn't needed. I suggest to change the prefix to something else, e.g.
[software_problem]