Port upstream 0.55.0: clarify Chinese quota labels - #379
Merged
Conversation
Finesssee
force-pushed
the
port/055-zh-cn-quota-label
branch
from
August 24, 2026 21:25
e889312 to
c01aa60
Compare
Collaborator
Author
Thermo-nuclear reviewThe initial port only special-cased the five-hour duration, while upstream steipete#3070 intentionally derives any whole-hour session quota from 1 through 12 hours and maps the weekly duration separately. That parity gap is now fixed, with focused Simplified Chinese tests for an arbitrary hourly duration and the weekly mapping. MenuCard tests pass 24/24, TypeScript no-emit typecheck passes, and the change remains narrowly scoped. Verdict: APPROVED. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sessionlabel and its real cadence is five hours, render5 小时for Simplified ChineseUpstream evidence
v0.55.01f77a5513/ Clarify five-hour quota wording in Simplified Chinese steipete/CodexBar#3070Validation
git diff --check-> passScope
Isolated localization/presentation port. No provider semantics or version bump.