Skip to content

fix: remove dead logModulesWithDynamicImports#7077

Open
serhalp wants to merge 5 commits into
mainfrom
fix/remove-dead-dynamic-imports-code
Open

fix: remove dead logModulesWithDynamicImports#7077
serhalp wants to merge 5 commits into
mainfrom
fix/remove-dead-dynamic-imports-code

Conversation

@serhalp

@serhalp serhalp commented May 28, 2026

Copy link
Copy Markdown
Member

Summary

This was orphaned years ago by ef4ab12c3.

@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 84e63ef2-2a04-4aa6-99d1-694ac413beef

📥 Commits

Reviewing files that changed from the base of the PR and between a63355e and 2428835.

📒 Files selected for processing (1)
  • packages/build/src/log/messages/core_steps.js
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • netlify/blueprints (manual)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/build/src/log/messages/core_steps.js

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes

    • Removed an incorrect build log warning about dynamic module imports, resulting in clearer and more accurate build output.
  • Chores

    • Simplified internal bundling log handling by stopping aggregation of dynamic-import module data and reducing related warning generation logic.

Walkthrough

This PR removes dynamic imports warning logging from bundle result processing. logBundleResults no longer derives the dynamic-import module list or invokes its warning logger, and the internal warning helper is deleted. Existing bundler error and esbuild warning logging remains unchanged.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is too minimal and misses the required Fixes #issue reference and most template sections. Add the issue reference, a clearer motivation, and the template checklist items or note why any are not applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately describes the main change: removing dead logModulesWithDynamicImports code.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/remove-dead-dynamic-imports-code

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@serhalp serhalp marked this pull request as ready for review May 28, 2026 14:09
@serhalp serhalp requested a review from a team as a code owner May 28, 2026 14:09
@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Actionable comments posted: 0

@serhalp serhalp requested a review from pieh June 24, 2026 14:52
@serhalp serhalp enabled auto-merge (squash) June 24, 2026 14:52
@github-actions

Copy link
Copy Markdown
Contributor

e18e dependency analysis

No dependency warnings found.

@pkg-pr-new

pkg-pr-new Bot commented Jul 16, 2026

Copy link
Copy Markdown

Open in StackBlitz

@netlify/build

npm i https://pkg.pr.new/@netlify/build@7077

@netlify/build-info

npm i https://pkg.pr.new/@netlify/build-info@7077

@netlify/cache-utils

npm i https://pkg.pr.new/@netlify/cache-utils@7077

@netlify/config

npm i https://pkg.pr.new/@netlify/config@7077

@netlify/edge-bundler

npm i https://pkg.pr.new/@netlify/edge-bundler@7077

@netlify/functions-utils

npm i https://pkg.pr.new/@netlify/functions-utils@7077

@netlify/git-utils

npm i https://pkg.pr.new/@netlify/git-utils@7077

@netlify/headers-parser

npm i https://pkg.pr.new/@netlify/headers-parser@7077

@netlify/api

npm i https://pkg.pr.new/@netlify/api@7077

@netlify/nock-udp

npm i https://pkg.pr.new/@netlify/nock-udp@7077

@netlify/opentelemetry-sdk-setup

npm i https://pkg.pr.new/@netlify/opentelemetry-sdk-setup@7077

@netlify/opentelemetry-utils

npm i https://pkg.pr.new/@netlify/opentelemetry-utils@7077

@netlify/redirect-parser

npm i https://pkg.pr.new/@netlify/redirect-parser@7077

@netlify/run-utils

npm i https://pkg.pr.new/@netlify/run-utils@7077

@netlify/zip-it-and-ship-it

npm i https://pkg.pr.new/@netlify/zip-it-and-ship-it@7077

commit: 98af31f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants