-
Notifications
You must be signed in to change notification settings - Fork 6
Add Change Tracker KB folders, sidebar, and migrate initial articles #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
- Initialize Change Tracker KB section with category configuration - Migrate 4 articles from general KB section to Change Tracker - Add _category_.json configuration for Change Tracker KB - Re-tag articles with appropriate product metadata Restored from archived repository with clean commit history.
- Enable KB section in Change Tracker 8.0 and 8.1 sidebars - Create index.md landing page with welcome message and help section - Complete certificate article cleanup (remove unnecessary password references) - Update sidebar labels to distinguish between 403 and certificate articles
Pull Request Review: Change Tracker KB MigrationOverall Assessment✅ Approved with minor suggestions - This is a well-structured PR that successfully migrates 4 Change Tracker KB articles with proper organization and integration. The implementation follows repository conventions and provides a solid foundation for future KB consolidation. 🎯 StrengthsStructure & Organization
Sidebar Integration
Documentation Quality
📝 Code Quality ReviewFrontmatter ConsistencyAll KB articles include:
Markdown Quality
|
| Item | Status |
|---|---|
| Proper frontmatter | ✅ |
| Consistent formatting | ✅ |
| Valid markdown | ✅ |
| Category configuration | ✅ |
| Sidebar integration | ✅ |
| Knowledge article IDs | ✅ |
| No hardcoded credentials | ✅ |
| Index page present | ✅ |
💡 Suggestions for Future PRs
- Consider adding a migration tracking document to track which articles have been migrated from the general KB
- Version-specific documentation - If paths or procedures differ between 8.0 and 8.1, consider adding version callouts
- Cross-references - Add links between related KB articles where appropriate
- Screenshots - Consider adding visual aids for complex UI procedures (if available)
🎬 Conclusion
This PR successfully lays the groundwork for the Change Tracker KB consolidation project. The implementation is clean, follows established patterns, and integrates seamlessly with the existing documentation structure.
Recommendation: ✅ Approve and merge after addressing the minor newline issue in disk_space_occupied_by_core._files_in_gen_7_agent_servers.md.
Next Steps After Merge:
- Verify navigation works correctly after repository rebuild
- Test search functionality for the new articles
- Continue migrating remaining Change Tracker KB articles
Great work on this migration! The attention to detail and consistent formatting will make the Change Tracker KB section easy to maintain and expand. 👏
- Add missing newline to disk space article
- Fix XML formatting: use <Password>YourAgentPassword</Password>
- Correct platform-specific paths for 8.0/8.1:
- Windows: C:\ProgramData\NNT\gen7agent.app.netcore - Linux: /var/nnt/gen7agent.app.netcore/
- Linux binaries: /opt/nnt/gen7agentcore/bin/
- Replace broken kb.netwrix.com link with working docs links
- Add references to official Change Tracker documentation
- Separate Windows/Linux instructions in corrupt-errorevent article
PR Review SummaryThank you for this well-organized PR that initializes the Change Tracker Knowledge Base section. The migration is clean and the articles are well-structured. Below is my detailed review: ✅ Strengths1. Excellent PR Organization
2. Code Quality
3. Documentation Quality
4. Content Accuracy
🔍 Observations & Minor Suggestions1. File Naming ConventionSome filenames use underscores and periods inconsistently:
Suggestion: Consider using consistent kebab-case for better URL readability, though this is not critical since sidebar labels override the display names. 2. Security ConsiderationsThe articles appropriately:
Good practice: The articles avoid including real credentials or sensitive data in examples. 3. Missing NewlineThe certificate thumbprint article is missing a trailing newline at the end of the file. While not critical, it is a best practice to include one. 4. Content CompletenessThe disk space article is quite brief. Consider adding:
However, this is optional and the current content is functional. 🧪 Test CoverageWhat is Covered:
Recommended Additional Testing:
🎯 Final VerdictStatus: ✅ Approved with minor suggestions This is a high-quality PR that successfully:
The minor suggestions above are optional improvements and should not block merging. The PR is ready to merge once you have completed the navigation and link verification testing mentioned in your PR description. 📋 Checklist for Merge
Recommendation: Merge after completing the pending navigation and link verification tests. Great work on this migration! 🎉 |
chills66
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the first time I've built the documentation on my machine so I don't know if these observations are to do with my build or are a more widespread issue
-
When selecting 'Knowledge Base', nothing gets displayed in the main window. This is the same for all new menu items that appear under 'Knowledge Base'
-
Selecting the leaf nodes which contain the new content, they display correctly within the main window but the lhs menu disappears and navigating back doesn't go to any of the 'Knowledge Base' pages

Summary
Initializes the Change Tracker knowledge base folder and migrates 4 existing KB articles from the general KB section. This is the first phase of an ongoing project to consolidate all Change Tracker documentation into a dedicated KB section.
Changes Made
_category_.jsonconfiguration for Change Tracker KB foldercorrupt-errorevent-in-event-reportsdisk_space_occupied_by_core._files_in_gen_7_agent_serversrolling-log_fix_error_nnt.hub.serviceclient.hubadapter_-_certificate_thumbprint_does_not_match_trustrolling-log_fix_hub_connection_failed._403_server_message_ip_address_blocked_loginfailuresFiles Changed
Project Status
The majority of Change Tracker articles are not yet imported and will be added in subsequent phases.
Testing
devRestored from archived repository with clean commit history.
Archived PR: https://github.com/netwrix/docs-archive-2025-12-22/pull/447