Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,323 changes: 1,323 additions & 0 deletions app/schemas/com.nextcloud.client.database.NextcloudDatabase/103.json

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,8 @@ import com.owncloud.android.db.ProviderMeta
AutoMigration(from = 98, to = 99),
// manual migration used for 99 to 100
AutoMigration(from = 100, to = 101, spec = DatabaseMigrationUtil.ResetCapabilitiesPostMigration::class),
AutoMigration(from = 101, to = 102, spec = DatabaseMigrationUtil.ResetCapabilitiesPostMigration::class)
AutoMigration(from = 101, to = 102, spec = DatabaseMigrationUtil.ResetCapabilitiesPostMigration::class),
AutoMigration(from = 102, to = 103, spec = DatabaseMigrationUtil.ResetCapabilitiesPostMigration::class)
],
exportSchema = true
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,9 @@ data class CapabilityEntity(
@ColumnInfo(name = ProviderTableMeta.CAPABILITIES_CLIENT_INTEGRATION_JSON)
val clientIntegrationJson: String?,
@ColumnInfo(name = ProviderTableMeta.CAPABILITIES_MOD_REWRITE_WORKING)
val modRewriteWorking: Int?
val modRewriteWorking: Int?,
@ColumnInfo(name = ProviderTableMeta.CAPABILITIES_SHARING_JSON)
val sharingJson: String?
)

@Suppress("LongMethod", "ReturnCount")
Expand Down Expand Up @@ -238,6 +240,7 @@ fun CapabilityEntity?.toOCCapability(): OCCapability {
capability.hasValidSubscription = intToBoolean(this.hasValidSubscription)
capability.clientIntegrationJson = this.clientIntegrationJson
capability.modRewriteWorking = intToBoolean(this.modRewriteWorking)
capability.sharingJson = this.sharingJson

return capability
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
package com.nextcloud.utils.extensions

import android.content.Context
import com.nextcloud.android.common.ui.network.auth.ServerCredentials
import com.nextcloud.common.NextcloudClient
import com.owncloud.android.lib.common.OwnCloudClient
import com.owncloud.android.lib.common.OwnCloudClientFactory
Expand All @@ -27,3 +28,9 @@ fun OwnCloudClient.getPreviewEndpoint(localFileId: Long, x: Int, y: Int): String
localFileId +
"&x=" + (x / 2) + "&y=" + (y / 2) +
"&a=1&mode=cover&forceIcon=0"

/**
* Used in Android Common
*/
fun OwnCloudClient.toServerCredentials(baseURL: String): ServerCredentials =
ServerCredentials(baseURL, userIdPlain, credentials.authToken)
Original file line number Diff line number Diff line change
Expand Up @@ -2442,6 +2442,8 @@ private ContentValues createContentValues(String accountName, OCCapability capab

contentValues.put(ProviderTableMeta.CAPABILITIES_MOD_REWRITE_WORKING, capability.getModRewriteWorking().getValue());

contentValues.put(ProviderTableMeta.CAPABILITIES_SHARING_JSON, capability.getSharingJson());

return contentValues;
}

Expand Down Expand Up @@ -2641,6 +2643,8 @@ private OCCapability createCapabilityInstance(Cursor cursor) {

capability.setClientIntegrationJson(getString(cursor, ProviderTableMeta.CAPABILITIES_CLIENT_INTEGRATION_JSON));

capability.setSharingJson(getString(cursor, ProviderTableMeta.CAPABILITIES_SHARING_JSON));

capability.setModRewriteWorking(getBoolean(cursor, ProviderTableMeta.CAPABILITIES_MOD_REWRITE_WORKING));
}

Expand Down
3 changes: 2 additions & 1 deletion app/src/main/java/com/owncloud/android/db/ProviderMeta.java
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
*/
public class ProviderMeta {
public static final String DB_NAME = "filelist";
public static final int DB_VERSION = 102;
public static final int DB_VERSION = 103;

private ProviderMeta() {
// No instance
Expand Down Expand Up @@ -296,6 +296,7 @@ static public class ProviderTableMeta implements BaseColumns {
public static final String CAPABILITIES_HAS_VALID_SUBSCRIPTION = "has_valid_subscription";
public static final String CAPABILITIES_CLIENT_INTEGRATION_JSON = "client_integration_json";
public static final String CAPABILITIES_MOD_REWRITE_WORKING = "mod_rewrite_working";
public static final String CAPABILITIES_SHARING_JSON = "sharing_json";

//Columns of Uploads table
public static final String UPLOADS_LOCAL_PATH = "local_path";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -608,9 +608,12 @@ private void bindSharedAvatars(ListItemViewHolder holder, OCFile file) {
if (sharedAvatars.getChildCount() > 0) {
sharedAvatars.removeAllViews();
}
final var avatars = helper.getAvatarSharees(file, userId);
sharedAvatars.setAvatars(user, avatars, viewThemeUtils);
sharedAvatars.setOnClickListener(view -> ocFileListFragmentInterface.onShareIconClick(file));

helper.getAvatarSharees(file, user, userId, avatars -> {
sharedAvatars.setAvatars(user, avatars, viewThemeUtils);
sharedAvatars.setOnClickListener(view -> ocFileListFragmentInterface.onShareIconClick(file));
return Unit.INSTANCE;
});
}

private void bindListItemViewHolder(ListItemViewHolder holder, OCFile file) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,22 @@

package com.owncloud.android.ui.adapter.helper

import com.nextcloud.android.common.ui.network.auth.ServerCredentials
import com.nextcloud.android.common.ui.share.avatar.ShareAvatarRepository
import com.nextcloud.android.common.ui.share.model.api.share.Share
import com.nextcloud.client.account.User
import com.nextcloud.client.database.entity.FileEntity
import com.nextcloud.client.preferences.AppPreferences
import com.nextcloud.utils.extensions.filterFilenames
import com.nextcloud.utils.extensions.isTempFile
import com.nextcloud.utils.extensions.toServerCredentials
import com.owncloud.android.MainApp
import com.owncloud.android.datamodel.OCFile
import com.owncloud.android.lib.common.OwnCloudClientManagerFactory
import com.owncloud.android.lib.common.utils.Log_OC
import com.owncloud.android.lib.resources.shares.ShareType
import com.owncloud.android.lib.resources.shares.ShareeUser
import com.owncloud.android.lib.resources.status.NextcloudVersion
import com.owncloud.android.utils.FileSortOrder
import com.owncloud.android.utils.MimeTypeUtil
import kotlinx.coroutines.CoroutineScope
Expand Down Expand Up @@ -56,17 +64,51 @@ class OCFileListAdapterHelper {
}
}

fun getAvatarSharees(file: OCFile, userId: String?): List<ShareeUser> {
val sharees = file.sharees
val ownerId = file.ownerId
// TODO: check if server provides backward compatibility
fun getAvatarSharees(file: OCFile, user: User?, userId: String?, onComplete: (List<ShareeUser>) -> Unit) {
scope.launch {
val result = if (supportsUnifiedShare(user) && user != null) {
val credentials = getServerCredentials(user) ?: return@launch
val sourceId = file.remoteId
val repository = ShareAvatarRepository(credentials).fetchShareAvatars(sourceId)
repository?.toAvatarSharees() ?: listOf()
} else {
val sharees = file.sharees
val ownerId = file.ownerId

val ownerSharee = if (!ownerId.isNullOrEmpty() && ownerId != userId) {
ShareeUser(ownerId, file.ownerDisplayName, ShareType.USER).takeIf { it !in sharees }
} else {
null
}

listOfNotNull(ownerSharee) + sharees.asReversed()
}

val ownerSharee = if (!ownerId.isNullOrEmpty() && ownerId != userId) {
ShareeUser(ownerId, file.ownerDisplayName, ShareType.USER).takeIf { it !in sharees }
} else {
null
withContext(Dispatchers.Main) {
onComplete(result)
}
}
}

return listOfNotNull(ownerSharee) + sharees.asReversed()
private fun supportsUnifiedShare(user: User?): Boolean =
user?.server?.version?.isNewerOrEqual(NextcloudVersion.nextcloud_34) == true

private fun List<Share>.toAvatarSharees(): List<ShareeUser> = asSequence()
.flatMap { share -> share.invitedRecipients }
.distinctBy { recipient -> recipient.value }
.map { recipient -> ShareeUser(recipient.value, recipient.displayName, ShareType.USER) }
.toList()

@Suppress("TooGenericExceptionCaught")
private fun getServerCredentials(user: User): ServerCredentials? = try {
OwnCloudClientManagerFactory
.getDefaultSingleton()
.getClientFor(user.toOwnCloudAccount(), MainApp.getAppContext())
.toServerCredentials(user.server.uri.toString())
} catch (e: Exception) {
Log_OC.e(TAG, "Failed to create client for share avatars", e)
null
}

suspend fun prepareFileList(
Expand Down Expand Up @@ -200,4 +242,8 @@ class OCFileListAdapterHelper {
job?.cancel()
job = null
}

companion object {
private val TAG = OCFileListAdapterHelper::class.java.simpleName
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,18 @@ import androidx.fragment.app.Fragment
import androidx.lifecycle.lifecycleScope
import androidx.recyclerview.widget.LinearLayoutManager
import com.google.android.material.button.MaterialButton
import com.nextcloud.android.common.ui.share.initShareScreen
import com.nextcloud.android.common.ui.theme.utils.ColorRole
import com.nextcloud.client.account.User
import com.nextcloud.client.account.UserAccountManager
import com.nextcloud.client.di.Injectable
import com.nextcloud.client.network.ClientFactory
import com.nextcloud.client.utils.IntentUtil
import com.nextcloud.utils.extensions.getParcelableArgument
import com.nextcloud.utils.extensions.getTypedActivity
import com.nextcloud.utils.extensions.mergeDistinctByToken
import com.nextcloud.utils.extensions.setVisibleIf
import com.nextcloud.utils.extensions.toServerCredentials
import com.nextcloud.utils.mdm.MDMConfig.shareViaUser
import com.owncloud.android.R
import com.owncloud.android.databinding.FileDetailsSharingFragmentBinding
Expand Down Expand Up @@ -140,11 +143,17 @@ class FileDetailSharingFragment :

binding?.pickContactEmailBtn?.setOnClickListener { checkContactPermission() }

fetchSharees()
// TODO: REPLACE FAKE CONDITION
if (user?.server?.version?.isNewerOrEqual(NextcloudVersion.nextcloud_34) == true || 2 < 4) {
showUnifiedShare()
} else {
fetchSharees()
}

setupView()
}

override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View? {
override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View {
binding = FileDetailsSharingFragmentBinding.inflate(inflater, container, false)
return binding!!.getRoot()
}
Expand Down Expand Up @@ -177,6 +186,40 @@ class FileDetailSharingFragment :
// endregion

// region private methods
private fun showUnifiedShare() {
val binding = binding ?: return

binding.shareContainer.visibility = View.GONE
binding.unifiedShare.visibility = View.VISIBLE

val shimmerLayout = binding.shimmerLayout.root
shimmerLayout.clearAnimation()
shimmerLayout.visibility = View.GONE

val fileActivity = getTypedActivity(FileActivity::class.java)

viewLifecycleOwner.lifecycleScope.launch(Dispatchers.IO) {
val user = user ?: return@launch
val file = file ?: return@launch
val client = fileActivity?.clientRepository?.getOwncloudClient() ?: return@launch
val sourceId = file.remoteId ?: return@launch

val baseURL = user.server.uri.toString()
val serverCredentials = client.toServerCredentials(baseURL)
val internalLink = createInternalLink(user, file, capabilities)

withContext(Dispatchers.Main) {
binding.unifiedShare.initShareScreen(
viewModelStoreOwner = this@FileDetailSharingFragment,
sourceId = sourceId,
internalLink = internalLink,
credentials = serverCredentials,
colorScheme = viewThemeUtils.files.getColorScheme(fileActivity)
)
}
}
}

private fun initArguments(savedInstanceState: Bundle?) {
val args = (savedInstanceState ?: arguments) ?: return
file = args.getParcelableArgument(ARG_FILE, OCFile::class.java)
Expand Down
60 changes: 33 additions & 27 deletions app/src/main/res/layout/file_details_sharing_fragment.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,25 +5,25 @@
~ SPDX-FileCopyrightText: 2018 Andy Scherzinger <info@andy-scherzinger.de>
~ SPDX-License-Identifier: AGPL-3.0-or-later OR GPL-2.0-only
-->
<androidx.core.widget.NestedScrollView xmlns:android="http://schemas.android.com/apk/res/android"
<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:paddingTop="@dimen/standard_eight_padding">
android:layout_below="@id/appbar">

<FrameLayout
<androidx.core.widget.NestedScrollView
android:layout_width="match_parent"
android:layout_height="match_parent"
android:layout_below="@id/appbar">
android:paddingTop="@dimen/standard_eight_padding">

<LinearLayout
android:id="@+id/shareContainer"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:orientation="vertical"
android:visibility="gone"
tools:visibility="visible"
android:orientation="vertical">
tools:visibility="visible">

<LinearLayout
android:id="@+id/shared_with_you_container"
Expand Down Expand Up @@ -139,33 +139,33 @@
android:layout_marginHorizontal="@dimen/standard_margin"
android:layout_marginTop="@dimen/standard_half_padding"
android:layout_marginBottom="@dimen/standard_half_padding"
android:text="@string/send_copy_to"
app:icon="@drawable/file_link"
app:iconGravity="textStart"
android:text="@string/send_copy_to" />
app:iconGravity="textStart" />

<TextView
android:id="@+id/internal_share_headline"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:paddingStart="@dimen/standard_padding"
android:paddingEnd="@dimen/zero"
android:paddingTop="@dimen/standard_half_padding"
android:paddingEnd="@dimen/zero"
android:paddingBottom="@dimen/standard_half_padding"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:text="@string/internal_shares"
android:textAppearance="?android:attr/textAppearanceMedium" />

<TextView
android:id="@+id/internal_share_description"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:paddingStart="@dimen/standard_padding"
android:visibility="gone"
tools:visibility="visible"
android:paddingEnd="@dimen/zero"
android:paddingTop="@dimen/standard_half_padding"
android:paddingEnd="@dimen/zero"
android:paddingBottom="@dimen/standard_half_padding"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:text="@string/internal_share_description_end_to_end_encrypted"
android:textAppearance="?android:attr/textAppearanceMedium" />
android:textAppearance="?android:attr/textAppearanceMedium"
android:visibility="gone"
tools:visibility="visible" />


<androidx.recyclerview.widget.RecyclerView
Expand Down Expand Up @@ -193,12 +193,12 @@

<TextView
android:id="@+id/external_shares_headline"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:paddingStart="@dimen/standard_padding"
android:paddingEnd="@dimen/zero"
android:paddingTop="@dimen/standard_half_padding"
android:paddingEnd="@dimen/zero"
android:paddingBottom="@dimen/standard_half_padding"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:text="@string/external_shares"
android:textAppearance="?android:attr/textAppearanceMedium" />

Expand All @@ -209,9 +209,9 @@
android:layout_height="wrap_content"
android:layout_marginStart="@dimen/standard_margin"
android:layout_marginEnd="@dimen/standard_margin"
android:text="@string/create_link"
app:icon="@drawable/file_link"
app:iconGravity="textStart"
android:text="@string/create_link" />
app:iconGravity="textStart" />

<androidx.recyclerview.widget.RecyclerView
android:id="@+id/sharesList_external"
Expand All @@ -231,10 +231,16 @@
android:text="@string/show_all" />
</LinearLayout>

<include
layout="@layout/file_details_sharing_shimmer"
android:id="@+id/shimmer_layout"/>
</androidx.core.widget.NestedScrollView>

<androidx.compose.ui.platform.ComposeView
android:id="@+id/unifiedShare"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:visibility="gone" />

</FrameLayout>
<include
android:id="@+id/shimmer_layout"
layout="@layout/file_details_sharing_shimmer" />

</androidx.core.widget.NestedScrollView>
</FrameLayout>
Loading
Loading