Fix handling of storage that has multiple shared mounts - #271
Open
christoph-bessei wants to merge 2 commits into
Open
Fix handling of storage that has multiple shared mounts#271christoph-bessei wants to merge 2 commits into
christoph-bessei wants to merge 2 commits into
Conversation
…le shared mounts Signed-off-by: Christoph Bessei <28066477+christoph-bessei@users.noreply.github.com>
…le shared mounts Signed-off-by: Christoph Bessei <28066477+christoph-bessei@users.noreply.github.com>
christoph-bessei
force-pushed
the
bugfix/#254_resolve-file-from-accessible-mount
branch
from
August 24, 2026 10:37
bd9f527 to
546a21e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #254
Description
As described in #254 there are some edge cases where
$mounts[0]->getUser()->getUID()returns a user ID that has no access to a given file. This PR fixes this by iterating through the mounts until it finds a user with access to the given file.There might be cleaner solutions, but I wanted to reduce the changes as much as possible for an easier review. Assuming
$mounts[0]is working in most cases, the performance impact should be minimal.Notes
🤖 AI (if applicable)