templateManager: allow using regular document files as templates#5512
templateManager: allow using regular document files as templates#5512meven wants to merge 3 commits intonextcloud:mainfrom
Conversation
elzody
left a comment
elzody
left a comment
There was a problem hiding this comment.
Even though the issue you mentioned was already resolved with #5475, I think this change still makes sense. Don't forget to --signoff your commits so that the DCO passes.
git commit --amend --signoff --no-editIt seems like the static analysis error is unrelated to this change.
meven
force-pushed
the
private/meven/template-odt
branch
from
fd81e49 to
b2746f2
Compare
I somehow missed that, we have two codes paths to define which extensions are acceptable as templates now, It would be best to unify them I think rather than making them match. |
That makes sense. For now we can go ahead and merge this and then I will create a separate issue to track that. |
As Collabora Online does not support creating templates, allow the user to reuse documents created with richdocuments as templates. Collabora Online supports thoe as templates. Fixes: nextcloud#5277 Signed-off-by: Méven Car <meven.car@collabora.com>
elzody
force-pushed
the
private/meven/template-odt
branch
from
b2746f2 to
6033f3a
Compare
|
I would need to rebase, I think, github does not let me rebase. |
3 participants
As Collabora Online does not support creating templates, allow the user to reuse documents created with richdocuments as templates.
Collabora Online supports thoe as templates.
Fixes: #5277