Skip to content

[stable34] fix: make unified filter chip accessible - #63224

Open
kristian-zendato wants to merge 1 commit into
stable34from
fix/unified-search-chip-accessibility
Open

[stable34] fix: make unified filter chip accessible#63224
kristian-zendato wants to merge 1 commit into
stable34from
fix/unified-search-chip-accessibility

Conversation

@kristian-zendato

Copy link
Copy Markdown
Contributor

Summary

The remove control on unified search filter chips was a plain <span> with a click handler: it was not keyboard-focusable and had no accessible name, so screen reader and keyboard users could not remove an active filter.
This changes the control to a real <button> and adds a translated aria-label ("Remove filter: {text}") so assistive technology announces which filter will be removed. Styles were adjusted so the button keeps the previous visual appearance

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: kristian-zendato <kristian.zendato@nextcloud.com>
@kristian-zendato
kristian-zendato requested a review from a team as a code owner August 13, 2026 13:51
@kristian-zendato
kristian-zendato requested review from skjnldsv, sorbaugh and susnux and removed request for a team August 13, 2026 13:51
@github-actions github-actions Bot changed the title fix: make unified filter chip accessible [stable34] fix: make unified filter chip accessible Aug 13, 2026
@susnux susnux added this to the Nextcloud 34.0.3 milestone Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants