Skip to content

fix: Public link with multiple mounts #63241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SystemKeeper wants to merge 2 commits into
base: master
Choose a base branch
from
+52 −0
Open

fix: Public link with multiple mounts #63241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bdac18
fix(dav): Ensure we access a shareable node if multiple exist
SystemKeeper Aug 14, 2026
4c9ecf6
test: Add test for multi-mount public links
SystemKeeper Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions apps/dav/appinfo/v1/publicwebdav.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,17 @@ function (\Sabre\DAV\Server $server) use (
if (!$node) {
throw new \Sabre\DAV\Exception\NotFound();
}

// getFirstNodeById might return a node without share permission -> try to find a node which is shareable
if (!$node->isShareable()) {
foreach ($userFolder->getById($fileId) as $candidate) {
if ($candidate->isShareable()) {
$node = $candidate;
break;
}
}
}

$linkCheckPlugin->setFileInfo($node);

// If not readable (files_drop) enable the filesdrop plugin
Expand Down
11 changes: 11 additions & 0 deletions apps/dav/appinfo/v2/publicremote.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,17 @@
if (!$node) {
throw new NotFound();
}

// getFirstNodeById might return a node without share permission -> try to find a node which is shareable
if (!$node->isShareable()) {
foreach ($userFolder->getById($fileId) as $candidate) {
if ($candidate->isShareable()) {
$node = $candidate;
break;
}
}
}

$linkCheckPlugin->setFileInfo($node);

// If not readable (files_drop) enable the filesdrop plugin
Expand Down
30 changes: 30 additions & 0 deletions build/integration/dav_features/dav-v2-public.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,3 +110,33 @@ Feature: dav-v2-public
Then the downloaded zip file contains a folder named "testFolder/"
And the downloaded zip file contains a file named "testFolder/text.txt" with the contents of "/testshare/testFolder/text.txt" from "user0" data
And the downloaded zip file contains a file named "testFolder/image.png" with the contents of "/testshare/testFolder/image.png" from "user0" data

# After the link share was created the initiator gets a second, read-only path to the
# shared folder. Nodes are ordered by path descending, so "/z-child" is found before
# "/parent/z-child" and the shareable path has to be picked explicitly.
Scenario: Downloading a file from a public share of a folder the initiator can also reach without share permission
Given using new dav path
And As an "admin"
And user "user0" exists
And user "user1" exists
And As an "user0"
And user "user0" created a folder "/parent"
And user "user0" created a folder "/parent/z-child"
And User "user0" uploads file with content "shared content" to "/parent/z-child/text.txt"
And folder "/parent" of user "user0" is shared with user "user1" with permissions 31
And user "user1" accepts last share
And as "user1" creating a share with
| path | parent/z-child |
| shareType | 3 |
| permissions | 1 |
Then the OCS status code should be "100"
And the HTTP status code should be "200"
And save the last share data as "publicLink"
And folder "/parent/z-child" of user "user0" is shared with user "user1" with permissions 1
And user "user1" accepts last share
And restore the last share data from "publicLink"
And As an "user0"
Given using new public dav path
When Downloading public file "/text.txt"
Then the HTTP status code should be "200"
And Downloaded content should be "shared content"
Loading