Skip to content

[stable33] perf(sharing): Use new user field from VerifyMountEvent#17673

Open
icewind1991 wants to merge 3 commits intostable33from
backport/17046/stable33
Open

[stable33] perf(sharing): Use new user field from VerifyMountEvent#17673
icewind1991 wants to merge 3 commits intostable33from
backport/17046/stable33

Conversation

@icewind1991
Copy link
Copy Markdown
Member

@icewind1991 icewind1991 commented Apr 9, 2026


Since not all 33 versions will have the updated event, I've gated it behind method_exists calls, falling back to the existing logic.
A bit hacky, but the performance gains are to significant to leave behind.

Signed-off-by: Joas Schilling <coding@schilljs.com>
@icewind1991 icewind1991 added this to the 🍏 Next Patch (33) milestone Apr 9, 2026
@nickvergessen
Copy link
Copy Markdown
Member

Since not all 33 versions will have the updated event, I've gated it behind method_exists calls, falling back to the existing logic.

👍

@nickvergessen nickvergessen added bug feature: api 🛠️ OCS API for conversations, chats and participants feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings performance 🚀 labels Apr 10, 2026
Signed-off-by: Joas Schilling <coding@schilljs.com>
Copy link
Copy Markdown
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, pushed a commit to run CI against the server PR

@nickvergessen
Copy link
Copy Markdown
Member

OCA\Talk\Config::getAttachmentFolder(): Argument #1 ($userId) must be of type string, OC\User\LazyUser given, called in /home/runner/work/spreed/spreed/apps/spreed/lib/Share/Listener.php on line 79

🙈

@nickvergessen
Copy link
Copy Markdown
Member

nickvergessen commented Apr 10, 2026

Seems it now needs some more adjustments about the placeholders

But its not changed on main: https://github.com/nextcloud/spreed/blob/772c540f6ddf202d2e2e1bff8725d83fc236ce6d/tests/integration/features/sharing-4/transfer-ownership.feature

@icewind1991
Copy link
Copy Markdown
Member Author

Same error happens with nextcloud/server#57760 so it's an effect of the other share handling changes.

@nickvergessen
Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug feature: api 🛠️ OCS API for conversations, chats and participants feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings performance 🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants