Skip to content

fix: Displaying context menu at the wrong location - #2651

Open
SystemKeeper wants to merge 2 commits into
mainfrom
fix/noid/wrong-context-menu
Open

fix: Displaying context menu at the wrong location#2651
SystemKeeper wants to merge 2 commits into
mainfrom
fix/noid/wrong-context-menu

Conversation

@SystemKeeper

Copy link
Copy Markdown
Collaborator

When long-pressing at the wrong time, we will display the context-menu/preview-cell at the wrong location and even with the wrong content. That makes it problematic to execute the actions on the correct cells.

There were multiple issues:

  • The context menu active guard was not complete, a reload could happen between building the context menu and showing it
  • The preview cell we dequeued was never rendered/reused, so it would show the old content
  • Similar to the previous issue, the cell would be displayed at the wrong location
  • The background color we use for highlighting the cell was never correctly reset, which sometimes showed the selected background on the preview cell

馃 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Assisted-by: ClaudeCode:claude-opus-5
Signed-off-by: Marcel M眉ller <marcel-mueller@gmx.de>
@SystemKeeper
SystemKeeper requested a review from Ivansss August 10, 2026 21:08
Signed-off-by: Marcel M眉ller <marcel-mueller@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant