feat(chip): add selection mode and toggle behavior#2764
Draft
fredvisser wants to merge 15 commits intomainfrom
Draft
feat(chip): add selection mode and toggle behavior#2764fredvisser wants to merge 15 commits intomainfrom
fredvisser wants to merge 15 commits intomainfrom
Conversation
fredvisser
force-pushed
the
users/fvisser/chip-toggle
branch
from
fc883c7 to
33e0dc4
Compare
jattasNI
reviewed
Dec 1, 2025
Contributor
jattasNI
left a comment
jattasNI
left a comment
There was a problem hiding this comment.
Just reviewed API design, proposed behavior, and document structure so far, not actual implementation.
| @@ -145,12 +145,18 @@ We will provide styling for the `disabled` attribute state. | |||
| _Consider the accessibility of the component, including:_ | |||
|
|
|||
| - _Keyboard Navigation and Focus_ | |||
Contributor
There was a problem hiding this comment.
Can you update the API section above to include the new APIs too? The other md file seems more like copilot instructions for this specific feature but it's still helpful to keep the entire API summarized in this higher level spec.
Contributor
Author
There was a problem hiding this comment.
Updated the higher-level chip spec so the API section now includes the new public surface: selectable, selected, remove, and selected-change.
jattasNI
reviewed
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Adds support for
selection-modeon thenimble-chipcomponent to allow for toggleable chips. This enables use cases where chips act as filter toggles or selectable items.👩💻 Implementation
selectionModeattribute toChipcomponent.selectedstate and styling.tabindexto ensure proper accessibility for selectable chips.🧪 Testing
✅ Checklist