Add blazor and react wrapper for nimble chip#2925
Open
hellovolcano wants to merge 3 commits intomainfrom
Open
Conversation
hellovolcano
requested review from
jattasNI,
msmithNI and
rajsite
as code owners
jattasNI
approved these changes
Apr 13, 2026
| <div className="container-label">Chip</div> | ||
| <NimbleChip>Outline Chip</NimbleChip> | ||
| <NimbleChip appearance="block">Block Chip</NimbleChip> | ||
| <NimbleChip removable>Removable Chip</NimbleChip> |
Contributor
There was a problem hiding this comment.
In the Angular app we listen to the remove event and popup a message if the remove button is clicked. Not a must-have, but if it's easy to add equivalent functionality to this app, that would be good.
Contributor
There was a problem hiding this comment.
Same comment applies to the Blazor app.
| @@ -0,0 +1,7 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
Could you also update the component status table?
nimble/packages/storybook/src/docs/component-status.stories.ts
Lines 183 to 194 in 19ccfe6
|
|
||
| namespace NimbleBlazor; | ||
|
|
||
| public partial class NimbleChip : ComponentBase |
Contributor
There was a problem hiding this comment.
Looks like you're missing an EventCallback for Remove. You can see the banner for an example.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
A blazor client application needs the nimble chip.
👩💻 Implementation
🧪 Testing
Ran existing tests
Added and ran blazor tests
Manually verified
✅ Checklist