Allow process kwargs to get passed into manager#213
Open
mchristen-astranis wants to merge 2 commits into
Open
Conversation
| self._events = events | ||
| self._child = self._child_ctor(self.cmd, env=self.env, cwd=self.cwd) | ||
| process_kwargs = process_kwargs or {} | ||
| kwargs = dict( |
There was a problem hiding this comment.
Does this also override self.env and self.cwd? I guess it's best to merge env, cwd passed via process_kwargs
Author
There was a problem hiding this comment.
good point, I'll merge env instead of overwriting it. This will overwrite cwd if it's passed in, which should be the expected behavior, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
Managerdirectly it could be convenient to passkwargstoPopen. For example, you could setshelltoFalseto avoid using the shell. In general this PR should allow for greater flexibility when usingManagerdirectly while having no impact on the more standard CLI usage ofhoncho.