fix(service-database): support custom public host via fqdn field#2
Open
ningyang1988 wants to merge 1 commit intonextfrom
Open
fix(service-database): support custom public host via fqdn field#2ningyang1988 wants to merge 1 commit intonextfrom
ningyang1988 wants to merge 1 commit intonextfrom
Conversation
- Refactor getServiceDatabaseUrl() to use new getPublicHost() method - Add ServiceDatabase::normalizePublicHost() static helper for URL normalization - Add fqdn field to service database UI with Host / Domain input - Wire fqdn through syncDatabaseData() in Livewire component - Update public URL label from 'IP:PORT' to 'Host:PORT' Fixes coollabsio#2377
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STRAWBERRY
Issues
Category
Preview
Feature is additive and backwards-compatible. The existing public database URL display now accepts a custom host value when configured.
AI Assistance
If AI was used:
Testing
Contributor Agreement
Important