Skip to content

Conversation

@oesteban
Copy link
Member

Summary

  • allow BaseDataset to accept array-like data (HDF5 datasets, memmaps) with tolerant repr/eq helpers
  • preserve file-backed data when loading from HDF5 or NIfTI and optionally keep HDF5 handles open
  • add backing-resource tracking/close helper for datasets

Testing

  • python -m compileall -q src/nifreeze/data

Codex Task

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 73.83178% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.00%. Comparing base (62e5e43) to head (ec72e01).
⚠️ Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
src/nifreeze/data/base.py 72.83% 17 Missing and 5 partials ⚠️
src/nifreeze/data/pet.py 77.77% 3 Missing and 1 partial ⚠️
src/nifreeze/data/dmri/base.py 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #346      +/-   ##
==========================================
+ Coverage   79.62%   80.00%   +0.37%     
==========================================
  Files          30       30              
  Lines        1919     2005      +86     
  Branches      202      216      +14     
==========================================
+ Hits         1528     1604      +76     
- Misses        335      342       +7     
- Partials       56       59       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants