Skip to content

ci: use Visual Studio 2026 on windows-11-arm #3380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gengjiawen merged 2 commits into from
Oct 1, 2026
Merged

ci: use Visual Studio 2026 on windows-11-arm #3380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3618ac
ci: use Visual Studio 2026 on windows-11-arm
gengjiawen Sep 30, 2026
eb17eaf
test: mock VSSetup lookup in find-visualstudio tests
gengjiawen Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/visual-studio.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- os: windows-2025
msvs-version: 2026
- os: windows-11-arm
msvs-version: 2022 # Fix this when Visual Studio 2025 is released
msvs-version: 2026
runs-on: ${{ matrix.os }}
timeout-minutes: 30
steps:
Expand Down
4 changes: 1 addition & 3 deletions test/test-find-visualstudio.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,9 +674,7 @@ describe('find-visualstudio', function () {
}

function allVsVersions (finder) {
finder.findVisualStudio2017OrNewerUsingSetupModule = async () => {
return null
}
finder.findNewVSUsingSetupModule = async () => null
finder.findVisualStudio2017 = async () => {
const data0 = JSON.parse(fs.readFileSync(path.join(__dirname, 'fixtures',
'VS_2017_Unusable.txt')))
Expand Down
Loading