test: avoid EBUSY removing renamed host executable - #3381
Open
gengjiawen wants to merge 1 commit into
Open
gengjiawen wants to merge 1 commit into
gengjiawen wants to merge 1 commit into
Conversation
"addon works with renamed host executable" copied node to a fixed path in the temp directory and unlinked it right after running it. On Windows the just-exited executable can still be locked, which intermittently failed the test with "EBUSY: resource busy or locked, unlink ...notnode.exe". Use a fresh temp directory and remove it in a finally block with retries, like the other cleanups in the test suite.
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm run lint && npm testpassesDescription of change
addon works with renamed host executableintermittently fails on Windows (bothwindows-11-armandwindows-latest), e.g. this job:The test copies
nodeto a fixed path in the temp directory and unlinks it right after running it; on Windows the just-exited executable can still be locked. The unlink also wasn't in afinally, so a failed build left the file behind.The test now uses a fresh
mkdtempdirectory and removes it infinallywithmaxRetries: 3, retryDelay: 1000, matching thermcalls intest-install.js.