path: add escapeGlob and unescapeGlob#61269
Conversation
Expose minimatch escaping and unescaping capabilities on path module. Fixes: nodejs#61258
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61269 +/- ##
==========================================
+ Coverage 88.54% 89.70% +1.15%
==========================================
Files 704 695 -9
Lines 208734 214198 +5464
Branches 40271 41020 +749
==========================================
+ Hits 184823 192145 +7322
+ Misses 15932 14114 -1818
+ Partials 7979 7939 -40
🚀 New features to boost your workflow:
|
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
|
Hey, no interest? @nodejs/path |
|
@nodejs/path @nodejs/fs |
|
I am wondering, why not just expose |
|
Vendoring is an implem detail, not a commitment and I'd prefer to not couple the Node's API to a third-party dependency. Goal here is to provide stable, cross-platform glob semantic in Node rather than exposing raw |
path: add escapeGlob and unescapeGlob
Expose minimatch escaping and unescaping capabilities on path module.
Fixes: #61258
This is an implem proposal fix #61258 using
minimatchthat is already-vendored. Also feel free to -1 the change if you think it doesn't have its place there.