build: use CARGO environment variable if set#62421
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Apr 1, 2026
Merged
build: use CARGO environment variable if set#62421nodejs-github-bot merged 1 commit intonodejs:mainfrom
CARGO environment variable if set#62421nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
68 tasks
addaleax
approved these changes
Mar 24, 2026
RafaelGSS
approved these changes
Mar 24, 2026
legendecas
approved these changes
Mar 24, 2026
targos
approved these changes
Mar 24, 2026
marco-ippolito
approved these changes
Mar 24, 2026
lpinca
approved these changes
Mar 24, 2026
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
When enabling support for Temporal, check for the `CARGO` environment variable to locate the `cargo` binary (defaulting to `cargo` if not set) and use this to build `deps/crates`. This will allow using Cargo on systems where the Cargo binary name is suffixed with the version, e.g. `cargo-1.82` on Ubuntu 24.04.
Collaborator
Member
Author
|
(rebased to see if that makes the Windows flakes go away) |
Collaborator
targos
approved these changes
Apr 1, 2026
targos
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 7b8934d |
richardlau
added
dont-land-on-v20.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When enabling support for Temporal, check for the
CARGOenvironment variable to locate thecargobinary (defaulting tocargoif not set) and use this to builddeps/crates.This will allow using Cargo on systems where the Cargo binary name is suffixed with the version, e.g.
cargo-1.82on Ubuntu 24.04.