fix: eight memcpy operations in uvwasi components co... in fd_table.c#62531
Open
orbisai0security wants to merge 1 commit intonodejs:mainfrom
Open
fix: eight memcpy operations in uvwasi components co... in fd_table.c#62531orbisai0security wants to merge 1 commit intonodejs:mainfrom
orbisai0security wants to merge 1 commit intonodejs:mainfrom
Conversation
Eight memcpy operations in UVWASI components copy data from attacker-controlled sources (file paths, environment variables, argv parameters) without validating that source length fits within destination buffer boundaries
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Member
|
slop :/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
deps/uvwasi/src/fd_table.c.Vulnerability
V-001deps/uvwasi/src/fd_table.c:104Description: Eight memcpy operations in UVWASI components copy data from attacker-controlled sources (file paths, environment variables, argv parameters) without validating that source length fits within destination buffer boundaries. WASI applications can provide arbitrarily long strings through initialization parameters and file operations, causing these memcpy calls to write beyond allocated buffer boundaries and corrupt adjacent memory structures.
Changes
deps/uvwasi/src/fd_table.cVerification
Automated security fix by OrbisAI Security