net: fix SocketAddress.parse default port handling

[araujogui]

Fixes #62906

[Copilot]

Pull request overview

This PR fixes net.SocketAddress.parse() so it correctly preserves explicit default ports (notably :80) that are otherwise dropped by URL.parse() when using an http:// base, aligning behavior with expectations and documentation.

Changes:

• Update SocketAddress.parse() to derive the port from the raw input string rather than url.port.
• Simplify the parse return path to a single SocketAddress construction for both IPv4 and IPv6.
• Add regression tests covering IPv4/IPv6 with explicit ports 80 and 443.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
lib/internal/socketaddress.js	Fixes default-port handling by parsing the port from the raw input instead of URLParse(...).port.
test/parallel/test-socketaddress.js	Adds regression coverage ensuring explicit :80/:443 are preserved for both IPv4 and IPv6.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov]

Codecov Report

❌ Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.68%. Comparing base (6df4f7b) to head (8435ef4).
⚠️ Report is 67 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/socketaddress.js	95.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #62912      +/-   ##
==========================================
+ Coverage   89.67%   89.68%   +0.01%     
==========================================
  Files         712      712              
  Lines      221251   221260       +9     
  Branches    42391    42393       +2     
==========================================
+ Hits       198405   198438      +33     
+ Misses      14669    14629      -40     
- Partials     8177     8193      +16     

Files with missing lines	Coverage Δ
lib/internal/socketaddress.js	98.54% <95.00%> (-0.45%)	⬇️

... and 22 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/73051/

[cookesan]

I noticed one extra behavior change from parsing the port with lastIndexOf(':') and parseInt(): it can pick up a colon that belongs to userinfo rather than the host port.

For example, current main keeps these at port 0 because there is no host port:

SocketAddress.parse('user:80@5.6.7.8')
SocketAddress.parse('user:81@5.6.7.8')

With this patch they become ports 80 and 81 respectively. That may be acceptable if userinfo-shaped inputs are considered out of scope, but it is a behavior change beyond preserving explicit default host ports.

An alternative is to keep using the HTTP URL parse for the address and existing non-default ports, and only when url.port is empty ask a scheme with no default port for the port value. For example:

URLParse(`socket://${input}`).port

That preserves the existing URL host parsing while recovering explicit host ports like :80.

[araujogui]

I noticed one extra behavior change from parsing the port with lastIndexOf(':') and parseInt(): it can pick up a colon that belongs to userinfo rather than the host port.

For example, current main keeps these at port 0 because there is no host port:

SocketAddress.parse('user:80@5.6.7.8')
SocketAddress.parse('user:81@5.6.7.8')

With this patch they become ports 80 and 81 respectively. That may be acceptable if userinfo-shaped inputs are considered out of scope, but it is a behavior change beyond preserving explicit default host ports.

An alternative is to keep using the HTTP URL parse for the address and existing non-default ports, and only when url.port is empty ask a scheme with no default port for the port value. For example:

URLParse(`socket://${input}`).port

That preserves the existing URL host parsing while recovering explicit host ports like :80.

Great finding and solution, thank you @cookesan

[araujogui]

I noticed one extra behavior change from parsing the port with lastIndexOf(':') and parseInt(): it can pick up a colon that belongs to userinfo rather than the host port.
For example, current main keeps these at port 0 because there is no host port:

SocketAddress.parse('user:80@5.6.7.8')
SocketAddress.parse('user:81@5.6.7.8')

With this patch they become ports 80 and 81 respectively. That may be acceptable if userinfo-shaped inputs are considered out of scope, but it is a behavior change beyond preserving explicit default host ports.
An alternative is to keep using the HTTP URL parse for the address and existing non-default ports, and only when url.port is empty ask a scheme with no default port for the port value. For example:

URLParse(`socket://${input}`).port

That preserves the existing URL host parsing while recovering explicit host ports like :80.

Great finding and solution, thank you @cookesan

Actually, I did some benchmarks and noticed the double URL.parse solution is definitely simpler but ~25% slower than a string-based approach. So I pushed the string solution.