Skip to content

doc: fix callback example import in fs documentation#63912

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Rawal27:doc-fs-fix-callback-import
Jun 24, 2026
Merged

doc: fix callback example import in fs documentation#63912
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Rawal27:doc-fs-fix-callback-import

Conversation

@Rawal27

@Rawal27 Rawal27 commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Summary

The CommonJS example in the "Ordering of callback and promise-based operations"
section demonstrates callback-based usage but imports rename and stat
from node:fs/promises.

Since callback-based APIs are provided by node:fs, the example should
import from node:fs instead.

This change aligns the CommonJS example with the equivalent ESM example
and the callback API being demonstrated.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Jun 14, 2026
Signed-off-by: Rawal27 <obviouslykamal@gmail.com>
@Rawal27 Rawal27 force-pushed the doc-fs-fix-callback-import branch from d4b08e9 to 61474ac Compare June 16, 2026 13:39
@Rawal27

Rawal27 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

Hi, just checking in on this PR. All CI checks are passing, and the review was approved a while ago. Please let me know if there's anything else needed from my side. Thanks!

@trivikr trivikr added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 24, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 24, 2026
@nodejs-github-bot nodejs-github-bot merged commit 23c6db5 into nodejs:main Jun 24, 2026
19 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 23c6db5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants