fix(socks5): encode embedded IPv4 tails in IPv6 literals correctly#5099
Merged
mcollina merged 1 commit intonodejs:mainfrom Apr 24, 2026
Merged
fix(socks5): encode embedded IPv4 tails in IPv6 literals correctly#5099mcollina merged 1 commit intonodejs:mainfrom
mcollina merged 1 commit intonodejs:mainfrom
Conversation
Assisted-by: openai:gpt-5.4 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5099 +/- ##
==========================================
+ Coverage 93.13% 93.14% +0.01%
==========================================
Files 110 110
Lines 35816 35840 +24
==========================================
+ Hits 33356 33382 +26
+ Misses 2460 2458 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Fixes: #5098
Rationale
parseIPv6()in the SOCKS5 utilities treated each post-::segment as a hexadecimal hextet. That breaks valid IPv6 literals with an embedded IPv4 tail, causing Undici to write the wrong 16-byte destination address into SOCKS5 connect requests.Changes
Normalize embedded IPv4 tails in
parseIPv6()before expanding compressed IPv6 notation.Features
N/A
Bug Fixes
Correct SOCKS5 IPv6 address encoding for IPv4-mapped IPv6 literals.
Breaking Changes and Deprecations
N/A
Status
Assisted-by: openai:gpt-5.4