fix: enforce maxCachedSessions in TLS session cache#5102
Merged
mcollina merged 1 commit intonodejs:mainfrom Apr 24, 2026
Merged
fix: enforce maxCachedSessions in TLS session cache#5102mcollina merged 1 commit intonodejs:mainfrom
mcollina merged 1 commit intonodejs:mainfrom
Conversation
Assisted-by: openai:gpt-5.4 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5102 +/- ##
==========================================
- Coverage 93.13% 93.13% -0.01%
==========================================
Files 110 110
Lines 35826 35842 +16
==========================================
+ Hits 33368 33381 +13
- Misses 2458 2461 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Fixes: #5100
Rationale
SessionCachecurrently relies onFinalizationRegistrycleanup to remove dead weak references, but it does not evict live entries when the cache reaches capacity. That allows_sessionCacheto grow beyondmaxCachedSessionsfor long-lived TLS sessions.Changes
SessionCache.set().Features
N/A
Bug Fixes
maxCachedSessionseven when cached TLS sessions are still alive.Breaking Changes and Deprecations
N/A
Status
Assisted-by: openai:gpt-5.4