Open
Conversation
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Member
|
There's an alternative PR which avoids response headers reserialization in #5085, which shows 5-7% improvement for similar tests. |
ronag
approved these changes
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optimize the HTTP/2 response header path in
client-h2by::statusBufferinstances for a bounded set of common response header namesThe header-name cache is intentionally bounded to avoid unbounded memory growth from attacker-controlled header names.
Validation
npx eslint lib/dispatcher/client-h2.jsnpm run test:h2:coreBenchmark notes
I verified this with a controlled A/B
.request()harness againstmainusing the same simple H2 server and interleaved runs.Average over 5 runs (
80 rounds x 200 parallel requests):2401.39msmain:2452.65msThat is roughly a 2.1% improvement on this request-heavy H2 workload.