Skip to content

fix: tanstack start package#1610

Merged
danielroe merged 3 commits intonpmx-dev:mainfrom
farisaziz12:fix/tanstack-start-package
Feb 23, 2026
Merged

fix: tanstack start package#1610
danielroe merged 3 commits intonpmx-dev:mainfrom
farisaziz12:fix/tanstack-start-package

Conversation

@farisaziz12
Copy link
Contributor

🧭 Context

In this PR, we added TanStack to the list of frameworks. In this comment, @schiller-manuel pointed out that the referenced package is now considered stale.

📚 Description

Updating the referenced package to the current most popular one, @tanstack/react-start

@vercel
Copy link

vercel bot commented Feb 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs.npmx.dev Ready Ready Preview, Comment Feb 23, 2026 6:43pm
npmx.dev Ready Ready Preview, Comment Feb 23, 2026 6:43pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
npmx-lunaria Ignored Ignored Feb 23, 2026 6:43pm

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 23, 2026

📝 Walkthrough

Walkthrough

This pull request updates a package reference within the SHOWCASED_FRAMEWORKS array in app/utils/frameworks.ts. Specifically, the package name for the "tanstack start" entry is changed from '@tanstack/start-server-core' to '@tanstack/react-start'. This is a direct string value modification with no changes to function signatures, types, or control flow logic.

Possibly related PRs

  • npmx-dev/npmx.dev PR 1523: Modifies the same SHOWCASED_FRAMEWORKS entry for "tanstack start" with related package name updates.

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The PR description clearly relates to the changeset, explaining the context, rationale, and specific package update from '@tanstack/start-server-core' to '@tanstack/react-start'.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
app/utils/frameworks.ts (1)

65-68: LGTM — @tanstack/react-start is the correct, actively maintained package.

@tanstack/react-start is current on npm (latest 1.162.2, published 12 hours ago) and is the canonical install target per the official TanStack Start docs, confirming this replaces the stale reference appropriately.

One optional consideration: the name field remains the generic 'tanstack start', while package now specifically anchors to the React variant. @tanstack/solid-start exists as a separate framework-specific package, so if a Solid variant is ever added to this list, the current name could become ambiguous. Renaming to something like 'tanstack start (react)' would pre-empt that confusion, but this is purely a forward-looking nitpick.


ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4e6e168 and f379d6c.

📒 Files selected for processing (1)
  • app/utils/frameworks.ts

@farisaziz12 farisaziz12 changed the title fix: TanStack Start Package fix: TanStack Start package Feb 23, 2026
@farisaziz12 farisaziz12 changed the title fix: TanStack Start package fix: tanstack start package Feb 23, 2026
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already fixed it. the package currently in the code includes more downloads than the react version (as it is depended on by both react and solid versions)

@farisaziz12
Copy link
Contributor Author

I already fixed it. the package currently in the code includes more downloads than the react version (as it is depended on by both react and solid versions)

But do we want to reference a sub-dependency of the frameworks or the framework itself?

on the page for @tanstack/start-server-core:

This package is not meant to be used directly. It is a dependency of the TanStack Start framework-specific packages.

imho it could confuse someone to point to something they should not use but references what they should use. WDYT?

@codecov
Copy link

codecov bot commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@danielroe danielroe added this pull request to the merge queue Feb 23, 2026
Merged via the queue into npmx-dev:main with commit 48bc139 Feb 23, 2026
17 checks passed
alex-key pushed a commit to alex-key/npmx.dev that referenced this pull request Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants