Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
📝 WalkthroughWalkthroughThis pull request updates a package reference within the SHOWCASED_FRAMEWORKS array in app/utils/frameworks.ts. Specifically, the package name for the "tanstack start" entry is changed from '@tanstack/start-server-core' to '@tanstack/react-start'. This is a direct string value modification with no changes to function signatures, types, or control flow logic. Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
app/utils/frameworks.ts (1)
65-68: LGTM —@tanstack/react-startis the correct, actively maintained package.
@tanstack/react-startis current on npm (latest 1.162.2, published 12 hours ago) and is the canonical install target per the official TanStack Start docs, confirming this replaces the stale reference appropriately.One optional consideration: the
namefield remains the generic'tanstack start', whilepackagenow specifically anchors to the React variant.@tanstack/solid-startexists as a separate framework-specific package, so if a Solid variant is ever added to this list, the currentnamecould become ambiguous. Renaming to something like'tanstack start (react)'would pre-empt that confusion, but this is purely a forward-looking nitpick.
But do we want to reference a sub-dependency of the frameworks or the framework itself? on the page for
imho it could confuse someone to point to something they should not use but references what they should use. WDYT? |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
🧭 Context
In this PR, we added TanStack to the list of frameworks. In this comment, @schiller-manuel pointed out that the referenced package is now considered stale.
📚 Description
Updating the referenced package to the current most popular one,
@tanstack/react-start