feat(ui): add subheading to weekly downloads to clarify scope#1752
feat(ui): add subheading to weekly downloads to clarify scope#1752
Conversation
Clarifies that download stats are aggregated at the package level, not per version. Adds a subtitle prop to CollapsibleSection and uses it in the downloads sidebar to reduce user confusion. Closes #1670
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
lol you beat me to it ^^ |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
I think we can add a modal-subtitle prop to chartModal too, wdyt ? |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis pull request adds subtitle support across multiple Vue components and updates localisation. It introduces an optional Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (11)
app/components/CollapsibleSection.vueapp/components/Modal.client.vueapp/components/Package/ChartModal.vueapp/components/Package/WeeklyDownloadStats.vuei18n/locales/en.jsoni18n/locales/fr-FR.jsoni18n/schema.jsonlunaria/files/en-GB.jsonlunaria/files/en-US.jsonlunaria/files/fr-FR.jsontest/nuxt/components/PackageWeeklyDownloadStats.spec.ts
🔗 Linked issue
Resolves #1670
🧭 Context
The npm downloads API aggregates data at the package level only, not per version. Users could be misled when selecting a different version and seeing the same download stats. This change adds a clarifying subtitle to make this behaviour explicit upfront.
📚 Description
Added a subheading feature to the
CollapsibleSectioncomponent to display secondary text below section headings. The weekly downloads section now displays "Across all versions" as a subheading below "Weekly Downloads".Add the same to the chart modal when downloads is selected: