Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
When the dev server runs on another port, you can't auth because it redirects back to to port 3000.
serhalp
force-pushed
the
serhalp/fix-auth-redirect-port
branch
from
89e219e to
8f4b884
Compare
| const { previewUrl, productionUrl } = await getEnv(nuxt.options.dev) | ||
| const clientUri = productionUrl || previewUrl || 'http://127.0.0.1:3000' | ||
| const { devUrl, previewUrl, productionUrl } = await getEnv(nuxt.options.dev) | ||
| const clientUri = productionUrl || previewUrl || devUrl || 'http://127.0.0.1:3000' |
There was a problem hiding this comment.
We still need this final fallback for the test env.
📝 WalkthroughWalkthroughThe pull request introduces Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| const nuxt = useNuxt() | ||
| const devUrl = isDevelopment ? `http://127.0.0.1:${nuxt.options.devServer.port}` : undefined |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# First, locate and inspect config/env.ts around lines 153-154
find . -name "env.ts" -path "*/config/*" | head -5Repository: npmx-dev/npmx.dev
Length of output: 76
🏁 Script executed:
# Check the structure around lines 153-154 in config/env.ts
fd "env.ts" -p "config" | head -1 | xargs wc -lRepository: npmx-dev/npmx.dev
Length of output: 78
🏁 Script executed:
# Get the actual content around lines 153-154
fd "env.ts" -p "config" | head -1 | xargs cat -n | sed -n '145,165p'Repository: npmx-dev/npmx.dev
Length of output: 729
🏁 Script executed:
# Also check modules/oauth.ts to verify the fallback logic
fd "oauth.ts" -p "modules" | head -1 | xargs cat -n | sed -n '1,30p'Repository: npmx-dev/npmx.dev
Length of output: 1289
🏁 Script executed:
# Search for the getEnv function definition to understand context
rg "function getEnv|const getEnv" -B 2 -A 5Repository: npmx-dev/npmx.dev
Length of output: 365
🌐 Web query:
Nuxt 4.3.1 devServer.port type definition and whether it is guaranteed to be defined
💡 Result:
Type definition (Nuxt 4.3.1)
- In
nuxt.config.ts(user config),devServer.portis anumberand is optional (you can omit it). The config reference documents it as:- Type:
number - Default:
3000[1]
- Type:
Is it guaranteed to be defined?
- In resolved Nuxt options (
nuxt.options),devServer.portis treated as defined (Nuxt applies defaults). Thenuxt devcommand docs show the fallback chain ending innuxtOptions.devServer.port(not optional-chained), which implies Nuxt expects it to exist after resolution. [2]
Practical takeaway
- If you’re reading the user’s raw config object, it may be
undefined(because it’s optional in config). - If you’re reading
nuxt.options.devServer.portinside Nuxt/module hooks after config resolution, you can generally treat it as anumber(defaulting to3000unless overridden by CLI/env). [1][2]
Sources: [1] Nuxt config reference (devServer.port) [2] nuxt dev command docs (default resolution order)
🏁 Script executed:
# Check if there are any type definitions or nuxt.config in the repo
fd "nuxt.config" | head -5Repository: npmx-dev/npmx.dev
Length of output: 95
🏁 Script executed:
# Search for devServer port references in the codebase
rg "devServer\.port|devServer\?" -B 2 -A 2Repository: npmx-dev/npmx.dev
Length of output: 350
🏁 Script executed:
# Check if there's package.json to verify Nuxt version
cat package.json | grep -A 2 -B 2 '"nuxt"'Repository: npmx-dev/npmx.dev
Length of output: 196
🏁 Script executed:
# Search for all calls to getEnv to verify it's only called in module context
rg "getEnv\(" -B 2 -A 2Repository: npmx-dev/npmx.dev
Length of output: 1248
🏁 Script executed:
# Also check the full context of config/env.ts to see if there are any type annotations
cat -n config/env.ts | head -20Repository: npmx-dev/npmx.dev
Length of output: 937
🏁 Script executed:
# Check nuxt.config.ts to see how devServer is configured in this project
cat nuxt.config.tsRepository: npmx-dev/npmx.dev
Length of output: 10471
Add defensive check for devServer.port to align with strict type-safety guidelines.
Line 154 accesses nuxt.options.devServer.port without validation. Although Nuxt resolves this to a default value of 3000 in module setup hooks, the code should align with the coding guideline requiring strictly type-safe access patterns. A defensive check would improve code robustness:
const nuxt = useNuxt()
const devPort = nuxt.options.devServer?.port
const devUrl = isDevelopment && typeof devPort === 'number' ? `http://127.0.0.1:${devPort}` : undefinedThis ensures devUrl is only set when a valid port is present, maintaining consistency with the fallback chain in modules/oauth.ts line 16.
1 participant
🔗 Linked issue
N/A - just found this while working on something else
🧭 Context
When the dev server runs on another port, you can't auth because it redirects back to to port 3000.
📚 Description
Use the nuxt dev server port instead of hardcoding