fix(ui): versions modal usage button copy#2007
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughSwaps two toggle button labels in the VersionDistribution component (first button now shows “most used”, second shows “all”), renames the i18n key Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
i18n/locales/de-DE.json (1)
358-383: Consider addinggrouping_usage_most_usedwhile this locale is already being touched.
app/components/Package/VersionDistribution.vuenow readspackage.versions.grouping_usage_most_used, andi18n/schema.jsondefines that key as part of the versions-modal toggle. This file still only providesgrouping_usage_all, so the German modal will fall back for one of the two labels the PR is explicitly rewording.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 085d6845-f947-4fa3-98b1-6e31d4984740
📒 Files selected for processing (18)
app/components/Package/VersionDistribution.vuei18n/locales/az-AZ.jsoni18n/locales/bg-BG.jsoni18n/locales/cs-CZ.jsoni18n/locales/de-DE.jsoni18n/locales/en.jsoni18n/locales/es.jsoni18n/locales/fr-FR.jsoni18n/locales/hu-HU.jsoni18n/locales/id-ID.jsoni18n/locales/ja-JP.jsoni18n/locales/pl-PL.jsoni18n/locales/ru-RU.jsoni18n/locales/tr-TR.jsoni18n/locales/uk-UA.jsoni18n/locales/zh-CN.jsoni18n/locales/zh-TW.jsoni18n/schema.json
💤 Files with no reviewable changes (4)
- i18n/locales/ja-JP.json
- i18n/locales/zh-CN.json
- i18n/locales/uk-UA.json
- i18n/locales/cs-CZ.json
| "files_count": "{count} fayl", | ||
| "lines_hidden": "{count} sətir gizlədilib", | ||
| "compare_versions": "fərq", | ||
| "compare_versions_title": "Versiyaları müqayisə et", |
There was a problem hiding this comment.
Align this tooltip with the actual compare target.
This key is used for the button that compares the current package version with the latest one. “Versiyaları müqayisə et” reads like a generic compare action, so it no longer matches the button’s behaviour closely enough.
| "grouping_usage_title": "Usage", | ||
| "grouping_usage_all": "All", | ||
| "grouping_usage_low": "Low", | ||
| "grouping_usage_most_used": "Most used", | ||
| "recent_versions_only_tooltip": "Show only versions published within the last year.", | ||
| "show_low_usage_tooltip": "Include version groups with less than 1% of total downloads.", |
There was a problem hiding this comment.
Most used still overstates what this filter does.
This toggle hides version groups below the 1% threshold; it does not isolate only the highest-usage versions. A label like “Excluding low” or “Hide low-usage” would match the graph behaviour and the tooltip more closely.
| "lines_hidden": "{count} satır gizlendi", | ||
| "file_too_large": "Dosya çok büyük", | ||
| "file_size_warning": "Dosya boyutu {size}", | ||
| "compare_versions_title": "Sürümleri karşılaştır", |
There was a problem hiding this comment.
Keep the “latest version” meaning in this label.
app/pages/package/[[org]]/[name].vue uses this key as the tooltip for the button that compares the current version against the latest one. “Sürümleri karşılaştır” is broader than the actual action, so the tooltip becomes less precise than the UI behaviour.
There was a problem hiding this comment.
@MatteoGabriele what's your take on the rabbit's ramblings ?
There was a problem hiding this comment.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
There was a problem hiding this comment.
That I don't speak Turkish? 😅
There was a problem hiding this comment.
@graphieros Jokes aside, I guess it's about a slightly less meaningful sentence for this language? But honestly, I'm not sure. Missing keys will fallback to English, and the other one has the same copy.
graphieros
left a comment
graphieros
left a comment
There was a problem hiding this comment.
LGTM :) Labels are now more understandable.
2 participants
🔗 Linked issue
resolves #1935
📚 Description
The copy of the usage section buttons does not match what the graph shows.
For the "Usage" section use
Most Used | Allbefore
after
