fix: increase minimum protobuf version to 6.31.1#318
Conversation
64d78e9 to
0fcd3c5
Compare
Signed-off-by: Kevin Neal <Kevin_Neal@intuit.com>
0fcd3c5 to
e0be6bf
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #318 +/- ##
=======================================
Coverage 94.00% 94.00%
=======================================
Files 66 66
Lines 3087 3087
Branches 156 156
=======================================
Hits 2902 2902
Misses 138 138
Partials 47 47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vigith
left a comment
There was a problem hiding this comment.
i am not sure why our grpc server fails with 6.31.0 while 6.31.1 works; as per https://protobuf.dev/support/cross-version-runtime-guarantee/ (except for cpp and rust) they are compatible across minor versions
@BulkBeing, could you please take a look into this?
|
It appears you used 6.31.1 to generate the code, so it requires at least that version of runtime.
|
|
We use python |
|
I see several files were updated in this PR from "Protobuf Python Version: 4.25.1" to "Protobuf Python Version: 6.31.1": |
|
@kohlisid/@BulkBeing, should we rollback our proto files or go ahead with bumping up |
|
I think we should bump the proto up @vigith |
What
Increase the minimum version of package "protobuf" to 6.31.1
Why
Using an older (lower) version of protobuf causes a runtime error.
To reproduce: