refactor(core_editor): extract grapheme boundary helpers into free functions#1068
Merged
fdncred merged 1 commit intonushell:mainfrom May 9, 2026
Merged
Conversation
…nctions Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
kronberger-droid
force-pushed
the
grapheme-helpers
branch
from
ad3ca9a to
0b5124c
Compare
kronberger-droid
changed the title
Contributor
|
nice cleanup! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts grapheme-boundary computation out of
LineBufferinto a siblinggraphemesmodule as free functions over&str.The two affected
LineBuffermethods become one-line wrappers and behavior is unchanged.The existing methods only ever touched
self.lines, so promoting them to free functions gives one source of truth for grapheme math reedline-wide.Side benefit: deduplicates the
next_back().map(...).unwrap_or(0)pattern inword_right_end_indexandbig_word_right_end_index.Also unblocks helix-mode operations (#1061 and follow-ups) that need to operate on
&strrather than&LineBuffer.14 unit tests cover ASCII, multi-byte UTF-8, CJK, combining marks, ZWJ emoji sequences, and round-trip invariants. Full suite (835) unchanged.