Repository navigation
feat(devtools): drive Vite DevTools through the devtools config option on Vite 8.3+ - #1091
Conversation
…ion on Vite 8.3+ Vite 8.3 registers the Vite DevTools integration itself from the top-level `devtools` config option (vitejs/vite#23333), so configure it there instead of installing the `DevTools()` plugin manually — users can now toggle the integration off with `vite: { devtools: false }` in `nuxt.config`. Older Vite versions keep the lazily installed plugin as a fallback. The nuxt5 ecosystem playground now pins Vite 8.3+ to exercise the config-driven path; nuxt4 stays on Vite 8.1 to cover the fallback.
Deploying nuxt-devtools with
|
| Latest commit: |
2893b48
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://be8afd28.nuxt-devtools.pages.dev |
| Branch Preview URL: | https://feat-vite-devtools-config-in.nuxt-devtools.pages.dev |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe module now detects the Vite version and configures DevTools through Vite’s top-level Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to No concrete current-head issue remains that should block merging. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔗 Linked issue
📚 Description
Vite 8.3 registers the Vite DevTools integration itself from the top-level
devtoolsconfig option (vitejs/vite#23333). This PR detects the running Vite version:DevTools()plugin manually. It seeds the Vitedevtoolsconfig option (branding, andclientAuthfordisableAuthorization) and lets Vite core load the integration. This puts the toggle in user hands:vite: { devtools: false }innuxt.configturns Vite DevTools off, and user-provideddevtoolsconfig keys win over our defaults.@vitejs/devtoolsand registering theDevTools()plugin, as before.Verified against
playgrounds-ecosystem/:/__devtools/with Nuxt branding in__connection.json, dock (devframes-dock-embedded) renders in the browser, Nuxt client served at/__nuxt_devtools__/client/; withvite: { devtools: false }the hub is not mounted.build+typecheckpass.build+typecheckpass.Also documents the new toggle in the v4 migration guide.
This PR was created with the help of an agent.