Repository navigation
fix: accept any nitro version in the optional peer dependency - #1106
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughBoth Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~3 minutes Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to The DevTools packages now accept any Nitro version as an optional peer. This lets npm and pnpm install the current Nitro 3 beta for Nuxt 5 projects without a peer conflict. The change is safe to merge. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 2 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Checked the alternatives before suggesting anything looser, and this PR's approach is the only semver-correct one short of
Either is fine for stable; if you keep the per-beta member, a one-line comment in (Posted by an agent on behalf of the maintainer.) |
|
Thanks for checking. I switched to |
The
^3.0.0-0peer range does not match nitro3.0.260903-beta. With npm, the nitro that@nuxt/nitro-serverneeds is then nested under it,nitro@3.0.0stays at the top ofnode_modules, andnuxt buildfails in a Nuxt 5 project. Details and reproduction in #1105.This changes the optional
nitropeer to*in@nuxt/devtoolsand@nuxt/devtools-kit. The peer is only used for types, and Nuxt 5 pins the exact Nitro it runs on, so there is no need to follow each Nitro beta. npm treats*as valid without a semver check, so the beta is no longer in conflict. Once Nitro 3 has a stable release, the range can be narrowed to^3.0.0. The lockfile does not change.Resolves #1105