Skip to content

ci: use pnpm/setup and devEngines - #263

Merged
danielroe merged 1 commit into
mainfrom
pnpm-setup
Sep 8, 2026
Merged

danielroe merged 1 commit into
mainfrom
pnpm-setup

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

📚 Description

this uses the new https://github.com/pnpm/setup github action to replace actions/setup-node + corepack, as corepack is going away in node 26+ 😢

@vercel

vercel Bot commented Sep 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
examples Ready Ready Preview Sep 8, 2026 6:19pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 2b6aeb71-fe64-4d13-abd5-a1f1389c97e0

📥 Commits

Reviewing files that changed from the base of the PR and between 3e87627 and 5a64d8b.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • .github/workflows/ci.yml
  • .github/workflows/playwright.yml
  • package.json

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The package configuration now requires Node.js ^24.0.0 and pnpm 12.3.4. The lint, typecheck, and Playwright workflows now use pnpm/setup with caching enabled and automatic pnpm installation disabled. Corepack and the previous Node.js setup steps were removed.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 5a64d

CI now uses pnpm setup with the repository’s declared Node.js and pnpm development-engine requirements. The workflow and package-manager version changes are aligned, with no current merge-blocking risk identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description explains the migration from actions/setup-node and Corepack to pnpm/setup. It matches the pull request changes and objectives.
Title check ✅ Passed The title clearly summarizes the main changes: adopting pnpm/setup and devEngines for CI.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch pnpm-setup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@danielroe
danielroe merged commit cdfe056 into main Sep 8, 2026
13 checks passed
@danielroe
danielroe deleted the pnpm-setup branch September 8, 2026 18:23

This branch was successfully deployed

1 active deployment
Preview — 5a64d8b1 Deployed Sep 8, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant