Skip to content

fix: allow icons query in cached handler for Nitro 3 - #542

Open
KazariAI wants to merge 1 commit into
nuxt:mainfrom
KazariAI:fix/cache-query-key
Open

KazariAI wants to merge 1 commit into
nuxt:mainfrom
KazariAI:fix/cache-query-key

Conversation

@KazariAI

Copy link
Copy Markdown
Contributor

Nitro 3 filters query parameters from cacheable handlers by default. Add allowQuery: ["icons"] so getKey() and the handler can access requested icons.


This pull request was created with assistance from a code agent.

@pkg-pr-new

pkg-pr-new Bot commented Oct 11, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/@nuxt/icon@542

commit: 754dcad

@coderabbitai

coderabbitai Bot commented Oct 11, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a18d5ab9-26d8-47d0-a599-06d656adb2c7

📥 Commits

Reviewing files that changed from the base of the PR and between b878f5b and 754dcad.


📒 Files selected for processing (1)
  • src/runtime/server/api.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.



📝 Walkthrough

Walkthrough

The cached icon handler configuration now allows the icons query parameter. The change also includes a TypeScript suppression for the Nitro 3 API.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes


Merge Risk: ⚪ Minimal · up to 754dc

The icons query is permitted for the cached handler as intended, with no actionable merge risk identified.

Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check Passed The description directly explains the Nitro 3 query-filtering issue and the added allowQuery configuration.
Title check Passed The title clearly and concisely identifies the fix for allowing the icons query in the cached handler for Nitro 3.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/runtime/server/api.ts

Parsing error: Unexpected token H3Event



Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant