Fix rejection handling of submissions#10127
Conversation
seanbudd
requested review from
SaschaCowley and
Copilot
and removed request for
a team
There was a problem hiding this comment.
Pull request overview
This PR adjusts the add-on submission automation to better handle manual-review rejections (including fetching and posting rejection reasons) and makes minor supporting documentation/data updates.
Changes:
- Refactors the manual-review rejection handling in
checkAndSubmitAddonMetadata.ymlto usegh api+jqand closes PRs with--delete-branch. - Adds a pre-merge
git pushand a short delay to reduce merge race conditions. - Updates reviewer documentation and a submitter entry.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
submitters.json |
Removes trustedSubmitter for one submitter entry. |
docs/dev/submissionReview.md |
Clarifies what reviewers should do when unsure during submitter review. |
.github/workflows/checkAndSubmitAddonMetadata.yml |
Refactors rejection-reason retrieval and improves PR/branch management around rejection + merge. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Sean Budd <seanbudd123@gmail.com>
| # checkout of repo needed for posting comments to issues | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v6 | ||
| with: | ||
| ref: ${{ env.branchName }} |
There was a problem hiding this comment.
Wouldn't it be more efficient to leave the checkout until after this check, and in "Warn if VT not set up correctly" do
gh -R "${{ github.repository }}" issue comment "${{ inputs.issueNumber }}" --body-file vt-not-set-up-correctly.md
| # wait for a few seconds to ensure the PR is up to date before merging | ||
| sleep 3 |
There was a problem hiding this comment.
Why is this necessary? git push is synchronous. This also seems very fragile.
There was a problem hiding this comment.
I was hoping this would fix whatever is causing #10139
Tested here: seanbudd#33
Fixup of #9877
Should close #10139
This pull request makes several improvements to the GitHub Actions workflow for add-on metadata submission, focusing on better automation, more robust handling of manual review rejections, and minor documentation and data updates. The most significant changes include refactoring how rejection reasons are fetched and posted, improving branch and PR management, and clarifying the submission review process.
Fixed AI slop that snuck into poorly tested previous PR:
.github/workflows/checkAndSubmitAddonMetadata.ymlto use a shell script withgh apiandjqfor fetching rejection reasons and reviewers, replacing the previousactions/github-scriptJavaScript approach. This makes the process more transparent and easier to debug.gh pr close ... --delete-branch, ensuring the branch is deleted remotely, and by adding agit pushbefore merging to guarantee the branch is up to date. Added a short delay before merging to avoid race conditions. [1] [2]