Skip to content

Regenerate json files, not translations#7368

Merged
seanbudd merged 1 commit into
nvaccess:masterfrom
nvdaes:regenerateJsonFiles
Jan 27, 2026
Merged

Regenerate json files, not translations#7368
seanbudd merged 1 commit into
nvaccess:masterfrom
nvdaes:regenerateJsonFiles

Conversation

@nvdaes

@nvdaes nvdaes commented Jan 24, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@nvdaes

nvdaes commented Jan 24, 2026

Copy link
Copy Markdown
Collaborator Author

This is related to nvaccess/addon-datastore-validation#55

All instances of regenerate translations, with or without spaces, should be renamed to regenerate json or regenerateJson. Also, messages and names in workflow should be updated accordingly, and actions have been updated: checkout and upload artifact to v6, and astral to v7.

I'm testing using my fork of addon-datastore-validation, and now the workflow seems to be running as expected:

https://github.com/nvdaes/addon-datastore/actions/runs/21311893602

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nvdaes

@seanbudd seanbudd merged commit b800e11 into nvaccess:master Jan 27, 2026
@seanbudd

Copy link
Copy Markdown
Member

This PR seems to have caused all this data to be deleted, not updated: b1f2a03

from https://github.com/nvaccess/addon-datastore/actions/runs/21386092611

I'll revert these changes ASAP

@nvdaes

nvdaes commented Jan 27, 2026

Copy link
Copy Markdown
Collaborator Author

Sorry, not sure what happened. Let me know if I can do something to fix this

@seanbudd

Copy link
Copy Markdown
Member

@nvdaes - can you try re-testing in your repos and fixing the transformation in addon-datastore-transform? It looks like it's deleting all the security scan information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants