fix(operators): remove new default grx LSP mapping#2324
fix(operators): remove new default grx LSP mapping#2324echasnovski merged 1 commit intonvim-mini:mainfrom
grx LSP mapping#2324Conversation
cbe880b to
f1d4d5e
Compare
f1d4d5e to
830d8f1
Compare
grx LSP mapping
|
Shall I add the new mapping to MiniMax as |
|
Thanks for the PR! Could you please more closely follow the 6a6a37e? I.e. almost the same set of changes and the almost the same commit message.
This is a bit early for MiniMax. Let's wait until the Neovim 0.12 release. Besides, I am not sure that |
Details: - Its presence conflicts with `gr` mapping.
830d8f1 to
0f0937e
Compare
Done |
echasnovski
left a comment
There was a problem hiding this comment.
Thanks! Looks better now.
I've only now realized that But at the same time, I've never really used codelens, so there is no mapping for it already. Do you know any particularly good use for it? Enough to warrant the extra |
No, I have never used it as well. I do think it makes sense for MiniMax to provide alternatives for builtin |
Details
New builtin lsp mapping "grx" executes
vim.lsp.codelens.run()See PR 37689 in neovim/neovim
This causes test 'Replace works with
cmdheight=0' to fail:Can not use
child.get_screenshotbecause child process is blocked.In mini.operators, default
gr*LSP mappings are removedI have read CONTRIBUTING.md
I have read CODE_OF_CONDUCT.md