This repository was archived by the owner on Dec 7, 2019. It is now read-only.
[WIP] File system erase ability#322
Open
bishiboosh wants to merge 1 commit intonytimes:feature/rx2from
Open
Conversation
| return Completable.concat(memCache | ||
| .asMap() | ||
| .keySet() | ||
| .stream() |
Contributor
There was a problem hiding this comment.
Isn't this java8 stream api? Won't work on android.
Contributor
|
Will hold off to merging until next major store version which we are starting to prepare. This is due to breaking change with current functionality. |
Author
|
@digitalbuddha sure. I've detected some problems with my code too, so I'll wait until the next version and come back to clean this then |
Contributor
|
howdy ho, will this be updated or should I close? |
Author
|
@digitalbuddha I don't think I have the time available right now, close it and I'll take another stab at it later :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added the clear functionality to the default file system persisters.
As the clear operation can take some times, I've also changed
clearsignature to beCompletable