This repository was archived by the owner on Dec 7, 2019. It is now read-only.
Add field in MemoryPolicy to control the duration of the Inflight Debouncer#374
Open
Eradash wants to merge 1 commit intonytimes:feature/rx2from
Open
Add field in MemoryPolicy to control the duration of the Inflight Debouncer#374Eradash wants to merge 1 commit intonytimes:feature/rx2from
Eradash wants to merge 1 commit intonytimes:feature/rx2from
Conversation
… control the duration of the Inflight Debouncer
Contributor
|
Thank you for the contribution, could you kindly add tests and fix the checkstyle voliation. Thank you |
| this.expireAfterAccess = expireAfterAccess; | ||
| this.expireAfterTimeUnit = expireAfterTimeUnit; | ||
| this.maxSize = maxSize; | ||
| this.maximumInFlightRequestsDurationInSeconds = maximumInFlightRequestsDurationInSeconds; |
Contributor
There was a problem hiding this comment.
I think allowing a timeunit + duration would be more consistent with rest of api
digitalbuddha
suggested changes
Dec 31, 2018
Contributor
digitalbuddha
left a comment
digitalbuddha
left a comment
There was a problem hiding this comment.
change to timeunit/tests and fix build :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed a shorter period of time for this variable, so I created a variable to make it custom.